Skip to content

[Build] Add Inputs/Outputs to _GenerateCompressedAssembliesNativeSourceFiles #11188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonathanpeppers wants to merge 4 commits into from
Closed

[Build] Add Inputs/Outputs to _GenerateCompressedAssembliesNativeSourceFiles #11188

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9866701
[Build] Add Inputs/Outputs to _GenerateCompressedAssembliesNativeSour…
jonathanpeppers Apr 22, 2026
aa5799f
Add build.props as Input to _GenerateCompressedAssembliesNativeSource…
jonathanpeppers Apr 22, 2026
17f0352
Touch output files so Inputs/Outputs comparison works correctly
jonathanpeppers Apr 22, 2026
3f0efb0
Add AndroidEnableAssemblyCompression to _PropertyCacheItems
jonathanpeppers Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public void BasicApplicationRepetitiveBuild ([Values] AndroidRuntime runtime)
Assert.IsTrue (
b.Output.IsTargetSkipped ("_Sign"),
"the _Sign target should not run");
b.Output.AssertTargetIsSkipped ("_GenerateCompressedAssembliesNativeSourceFiles");
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssertTargetIsSkipped ("_GenerateCompressedAssembliesNativeSourceFiles") is unconditional, but _GenerateCompressedAssembliesNativeSourceFiles is conditioned out when runtime == AndroidRuntime.NativeAOT. If the NativeAOT build path doesn’t invoke the target (and therefore doesn’t emit a “skipped” message), this assertion will fail. Consider guarding the assertion to non-NativeAOT runtimes, or pass defaultIfNotUsed: true for the NativeAOT case.

Suggested change
b.Output.AssertTargetIsSkipped ("_GenerateCompressedAssembliesNativeSourceFiles");
if (runtime != AndroidRuntime.NativeAOT) {
b.Output.AssertTargetIsSkipped ("_GenerateCompressedAssembliesNativeSourceFiles");
}

Copilot uses AI. Check for mistakes.
var item = proj.AndroidResources.First (x => x.Include () == "Resources\\values\\Strings.xml");
item.TextContent = () => proj.StringsXml.Replace ("${PROJECT_NAME}", "Foo");
item.Timestamp = null;
Expand Down
5 changes: 4 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,9 @@ because xbuild doesn't support framework reference assemblies.
</Target>

<Target Name="_GenerateCompressedAssembliesNativeSourceFiles"
Condition=" '$(_AndroidRuntime)' != 'NativeAOT' ">
Condition=" '$(_AndroidRuntime)' != 'NativeAOT' "
Inputs="@(_ResolvedUserAssemblies);@(_ResolvedFrameworkAssemblies);$(_AndroidBuildPropertiesCache)"
Outputs="@(_CompressedAssembliesAssemblySource)">
Comment thread
jonathanpeppers marked this conversation as resolved.
Comment thread
jonathanpeppers marked this conversation as resolved.
<GenerateCompressedAssembliesNativeSourceFiles
ResolvedAssemblies="@(_ResolvedUserAssemblies);@(_ResolvedFrameworkAssemblies)"
EnvironmentOutputDirectory="$(IntermediateOutputPath)android"
Expand All @@ -2006,6 +2008,7 @@ because xbuild doesn't support framework reference assemblies.
EnableCompression="$(AndroidEnableAssemblyCompression)"
ProjectFullPath="$(MSBuildProjectFullPath)"
/>
<Touch Files="@(_CompressedAssembliesAssemblySource)" />
<ItemGroup>
<FileWrites Include="@(_CompressedAssembliesAssemblySource)" />
</ItemGroup>
Expand Down