Rework Design Time Build to use .aar files directly. #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
dtbrework
branch
2 times, most recently
from
d08fdf2 to
8f05381
Compare
dellis1972
force-pushed
the
dtbrework
branch
from
373a6a5 to
f96ca96
Compare
dellis1972
force-pushed
the
dtbrework
branch
3 times, most recently
from
8b86bf8 to
ddc632f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dellis1972
requested review from
jonathanpeppers,
grendello and
jonpryor
as code owners
src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceCaseMap.cs
Outdated
Show resolved
Hide resolved
...amarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Resource.Designer.targets
Outdated
Show resolved
Hide resolved
...d.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...d.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceCaseMap.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Jan 14, 2025
|
I reran several of the test lanes. |
jonpryor
reviewed
Jan 15, 2025
| continue; | ||
| } | ||
| using (var file = File.OpenRead (aar)) { | ||
| using var zip = ZipArchive.Open (file); |
There was a problem hiding this comment.
Given #9623 and the apparent immense performance difference between Xamarin.Tools.Zip and System.IO.Compression, I think we should try using System.IO.Compression to read the .aar files, unless we require Xamarin.Tools.Zip for some reason…
jonpryor
reviewed
Jan 15, 2025
| continue; | ||
| } | ||
| using (var file = File.Open (aar, FileMode.Open, FileAccess.ReadWrite, FileShare.Read)) { | ||
| using var zip = ZipArchive.Open (file); |
There was a problem hiding this comment.
Given #9623 and the apparent immense performance difference between Xamarin.Tools.Zip and System.IO.Compression, I think we should try using System.IO.Compression to read the .aar files, unless we require Xamarin.Tools.Zip for some reason…
jonpryor
reviewed
Jan 15, 2025
| custom_types.Add (custom_id); | ||
| } | ||
| if (!string.IsNullOrEmpty (id)) { | ||
| CreateResourceField (custom_id ?? "id", id.Replace ("-", "_").Replace (".", "_"), resources); |
There was a problem hiding this comment.
I wonder if this should instead use a Regex to replace anything outside [A-Za-z][A-Za-z0-9_]* with _.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context dotnet/maui#25207
Also
designtimefolder.