-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests under CoreCLR #9863
base: main
Are you sure you want to change the base?
Run tests under CoreCLR #9863
Conversation
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
a29ba59
to
a9f513f
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
b90d3d1
to
aea3b79
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
15d87f9
to
d3e28de
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
026cd0f
to
f99ba5a
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
d6e6d70
to
e5d04ef
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
9e821b5
to
b47f929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the timeframe for 'official' support I think we may be better served by incrementally adding tests for additional runtime configurations? For instance, Peppers has a WIP Mono.Android tests flavor addition here #9916 which will bring in some CoreCLR coverage.
In addition to that, perhaps we could just parameterize one or more of the Build/Packaging and Deploy/Debug tests to run against CoreCLR for now, rather than duplicating all of our test stages?
As we get closer to 'official' support we'll need to reevaluate and determine whether we want all PR builds to run all tests against all runtime flavors (similar to the current approach in this PR). Some alternatives to this approach that may be worth considering would be:
- Adding duplicate test stages for new runtime flavors to the nightly build
- Creating additional separate pipeline(s) that can be triggered automatically or manually based on certain code path changes or when we otherwise determine we want additioinal runtime flavor coverage
b47f929
to
acbc518
Compare
This PR actually enables building of the CoreCLR host added to
main
in #9572The goal is to fix all the failing tests, possibly add new ones.