Skip to content

Add a second .NET path for MicroBuild #16091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a second .NET path for MicroBuild #16091

wants to merge 1 commit into from

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Aug 28, 2025 •
edited
Loading

Resolves #15731

  • Separates out .NET used for tooling and .NET used for MicroBuild
  • Adds logic to require .NET for MicroBuild when not dry run signing
  • Finds .NET for MicroBuild by searching the path for a dotnet executable in a MicroBuild folder, defaults to the DotNetTool executable if not found or on Windows.
  • Updates the install-microbuild.yml file to install MicroBuild sources into a temp directory and the .NET version required by MicroBuild into the same temp directory

Arcade-validation test build

@ellahathaway ellahathaway requested a review from mmitche August 28, 2025 22:48
@ellahathaway ellahathaway mentioned this pull request Aug 28, 2025
Open
mmitche
mmitche reviewed Sep 3, 2025
View reviewed changes
src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj
</PropertyGroup>

<ItemGroup Condition="'$(UseDotNetToolPathForMicroBuild)' == 'false'">
<_ItemInPath Include="$([System.Text.RegularExpressions.Regex]::Split('$(PATH)', ':'))" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use System.IO.Path.PathSeparator in place of :?

mmitche
mmitche reviewed Sep 3, 2025
View reviewed changes
src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj
<PropertyGroup Condition="$(_DotNetCoreRequired)">
<_DotNetCorePath>$(DotNetTool)</_DotNetCorePath>
<_DotNetPathMicroBuildCandidate
Include="@(_ItemInPath->'%(Identity)/dotnet')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If this code is used on Windows (e.g. UseDotNetToolPathForMicroBuild == false) then this would break...maybe replace dotnet with a property DotNetExe?

mmitche
mmitche reviewed Sep 3, 2025
View reviewed changes
src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj
<_DotNetPathMicroBuild>%(_DotNetPathMicroBuildCandidate.Identity)</_DotNetPathMicroBuild>
</PropertyGroup>

<Warning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because most repos turn on warnings as errors. I would make this a high importance log message instead.

@akoeplinger
Copy link
Member

I just ran into the microbuild-deleted-by-checkout issue again in a repo, would be nice to have this finally fixed :)

@ellahathaway
Copy link
Member Author

I just ran into the microbuild-deleted-by-checkout issue again in a repo, would be nice to have this finally fixed :)

Acknowledged :) This fell off of my radar with some of the other work I've been focusing on. I will have it completed by end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Signing] Avoid installing MicroBuild plugin to sources directory
3 participants
@ellahathaway @akoeplinger @mmitche