Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 15, 2025

This PR quarantines the test PublishCommandWithoutOutputPathUsesDefaultSubdirectory in the Aspire.Cli.Tests.Commands.PublishCommandTests class by adding the [QuarantinedTest] attribute.

The test was identified as flaky and needed to be excluded from regular CI test runs to prevent false failures. The test has been quarantined with a placeholder issue URL and will now only run in the dedicated quarantine test workflow.

Changes Made

  • Added [QuarantinedTest("https://github.com/dotnet/aspire/issues/9999")] attribute to the PublishCommandWithoutOutputPathUsesDefaultSubdirectory test method
  • The test will now be excluded from regular test runs (when --filter-not-trait "quarantined=true" is used)
  • The test can still be executed specifically in quarantine test workflows

Verification

  • ✅ Project builds successfully with no compilation errors
  • ✅ Regular test runs now exclude the quarantined test (test count reduced from 150 to 149 in the Commands namespace)
  • ✅ Quarantined tests can still be run specifically when needed

This follows the established pattern for quarantining flaky tests in the Aspire repository and ensures CI stability while preserving the test for future debugging and fixes.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI changed the title [WIP] Quarantine test PublishCommandWithoutOutputPathUsesDefaultSubdirectory Quarantine flaky test PublishCommandWithoutOutputPathUsesDefaultSubdirectory Sep 15, 2025
@Copilot Copilot AI requested a review from davidfowl September 15, 2025 03:59
Copilot finished work on behalf of davidfowl September 15, 2025 03:59
Copy link
Contributor

github-actions bot commented Sep 15, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11398

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11398"

@davidfowl davidfowl marked this pull request as ready for review September 15, 2025 04:22
@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 04:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR quarantines a flaky test to improve CI stability by adding the [QuarantinedTest] attribute to exclude it from regular test runs while preserving it for debugging purposes.

  • Added [QuarantinedTest("https://github.com/dotnet/aspire/issues/9999")] attribute to the PublishCommandWithoutOutputPathUsesDefaultSubdirectory test method
  • The test will be excluded from regular CI runs using the --filter-not-trait "quarantined=true" filter
  • Test remains available for execution in dedicated quarantine workflows

@radical radical merged commit d82f173 into main Sep 15, 2025
612 of 615 checks passed
@radical radical deleted the copilot/fix-cb925bdb-2a81-4299-8cb7-e15787f17fe0 branch September 15, 2025 15:06
@dotnet-policy-service dotnet-policy-service bot added this to the 9.5 milestone Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants