Disable Azure ServiceBus emulator functional tests #7067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emulator isn't reliable / consistent in CI. Disabling for now. See dotnet#7066
3 tasks
sebastienros
approved these changes
Jan 10, 2025
joperezr
reviewed
Jan 10, 2025
|
|
||
| <!-- on helix this will be available in the source dir --> | ||
| <XunitRunnerJson Condition="'$(RepoRoot)' == ''">xunit.runner.json</XunitRunnerJson> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(SkipUnstableEmulators)' == 'true'"> |
There was a problem hiding this comment.
NIT: Can this just be done in the parent's Directory.Build.props so it applies to both playground and tests and that way we don't have to change multiple places later?
Feel free to not block on this one, but just something to consider.
There was a problem hiding this comment.
Note that we already had this code in the repo.
- Orignally added in Add AzureFunctionsEndToEnd with prototype implementation #5418
- Renamed in Support connection name-based configuration for Azure components #5827
- Removed in Add Service Bus emulator support #6737
- and now brought back with another different name.
One reason to not put it in the root of the repo is so it doesn't affect other projects - like stuff under src.
joperezr
reviewed
Jan 10, 2025
| @@ -17,11 +17,17 @@ | |||
| <PlaygroundSourceDir>$(MSBuildThisFileDirectory)..\..\playground\</PlaygroundSourceDir> | |||
| <TestsSharedDir>$(MSBuildThisFileDirectory)..\Shared\</TestsSharedDir> | |||
| <RunSettingsFilePath>$(MSBuildThisFileDirectory).runsettings</RunSettingsFilePath> | |||
| <!-- Skip emulators that don't start consistently when running in CI. --> | |||
There was a problem hiding this comment.
NIT: I know you did it on the facts, but might be good to also add the link to the issue tracking removing this in here too. Also not block on this, if you agree we can add it in your next set of changes.
joperezr
approved these changes
Jan 10, 2025
github-actions
bot
added
the
area-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emulator isn't reliable / consistent in CI. Disabling for now.
See #7066