Trying out gha to run tests #7073
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jan 13, 2025
Comment on lines
+309
to
+318
| // Need to grant read access to the config file on unix like systems. | ||
| if (!OperatingSystem.IsWindows()) | ||
| { | ||
| // 777 | ||
| var permissions = UnixFileMode.UserRead | UnixFileMode.UserWrite | UnixFileMode.UserExecute | | ||
| UnixFileMode.GroupRead | UnixFileMode.GroupWrite | UnixFileMode.GroupExecute | | ||
| UnixFileMode.OtherRead | UnixFileMode.OtherWrite | UnixFileMode.OtherExecute; | ||
|
|
||
| File.SetUnixFileMode(serverFileMount.Source!, permissions); | ||
| } |
There was a problem hiding this comment.
This can be done as part of the call to CreateDirectory above:
public static class Directory
{
[UnsupportedOSPlatform("windows")]
public static DirectoryInfo! CreateDirectory(string! path, UnixFileMode unixCreateMode);
}
eerhardt
reviewed
Jan 13, 2025
| @@ -304,6 +306,17 @@ public static IResourceBuilder<PostgresServerResource> WithPgWeb(this IResourceB | |||
| Directory.CreateDirectory(serverFileMount.Source!); | |||
| } | |||
|
|
|||
| // Need to grant read access to the config file on unix like systems. | |||
There was a problem hiding this comment.
Why wasn't this needed before?
eerhardt
reviewed
Jan 13, 2025
| filter: "WithDataShouldPersistStateBetweenUsages" | ||
| - project: tests/Aspire.Hosting.PostgreSQL.Tests/Aspire.Hosting.PostgreSQL.Tests.csproj | ||
| name: PostgreSQL | ||
| filter: "Aspire.Hosting" |
There was a problem hiding this comment.
Are these filters just for now? I wouldn't expect us to use them when we did this for real.
eerhardt
reviewed
Jan 13, 2025
| @@ -61,7 +61,7 @@ public static TestDistributedApplicationBuilder Create(Action<DistributedApplica | |||
| return new TestDistributedApplicationBuilder(configureOptions, testOutputHelper); | |||
| } | |||
|
|
|||
| public static TestDistributedApplicationBuilder CreateWithTestContainerRegistry(ITestOutputHelper testOutputHelper) => | |||
| public static TestDistributedApplicationBuilder CreateWithTestContainerRegistry(ITestOutputHelper? testOutputHelper = null) => | |||
There was a problem hiding this comment.
I think this should be reverted. We always want an ITestOutputHelper to be passed so we get log output correctly.
eerhardt
reviewed
Jan 13, 2025
Comment on lines
+575
to
+581
| if (!OperatingSystem.IsWindows()) | ||
| { | ||
| var permissions = UnixFileMode.UserRead | UnixFileMode.UserWrite | UnixFileMode.UserExecute | | ||
| UnixFileMode.GroupRead | UnixFileMode.GroupWrite | UnixFileMode.GroupExecute | | ||
| UnixFileMode.OtherRead | UnixFileMode.OtherWrite | UnixFileMode.OtherExecute; | ||
|
|
||
| File.SetUnixFileMode(bindMountPath, permissions); |
There was a problem hiding this comment.
We shouldn't be doing this in the test - this seems like a product bug.
eerhardt
reviewed
Jan 13, 2025
| timeout-minutes: 60 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
Does this mean that for each test assembly we will get a separate job/leg in CI?
danmoseley
added
the
area-engineering-systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying this out