Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying an Event Hub to use as the default EntityPath for namespace connection string #7105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oising
Copy link
Contributor

@oising oising commented Jan 14, 2025

Description

  • Add new property to EventHub model: IsDefaultEntity

Only one EventHub can be specified as the default entity path. The entity path can still be overridden by settings in integrations.

  • Add test to validate EntityPath is in connection string, and is well-formed
  • Add test to validate setting multiple default entities is invalid
  • Updated playground to remove settings usage (but left setting usage in other tests)
  • Updated documentation in README.md for integrations to mention new functionality

Currently the design means validation is done late when the connection string is requested.

API review required.

image

Fixes #7093

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 14, 2025
@oising
Copy link
Contributor Author

oising commented Jan 14, 2025

If we can agree on tihs, I'll send a PR for the same thing in Azure Service Bus for queue/topic in EntityPath, or I can put it in this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying a default EntityPath for Azure Event Hubs / Azure Service Bus connection string
1 participant