Skip to content

Temporary workaround to fix filter dialog combobox #8450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 31, 2025

Description

Fixes #8343

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a temporary workaround to fix an issue with the filter dialog combobox by replacing the usage of FluentCombobox with a new component called FixedFluentCombobox. The key changes are:

  • Updated FilterDialog.razor to use FixedFluentCombobox instead of FluentCombobox.
  • Added FixedFluentCombobox.razor.cs implementing a temporary override of ChangeHandlerAsync.
  • Added FixedFluentCombobox.razor that simply delegates to the base component’s render tree.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Aspire.Dashboard/Components/Dialogs/FilterDialog.razor Replaced FluentCombobox with FixedFluentCombobox as a temporary fix.
src/Aspire.Dashboard/Components/Controls/FixedFluentCombobox.razor.cs Added a new temporary component that overrides ChangeHandlerAsync using a nested async delegate.
src/Aspire.Dashboard/Components/Controls/FixedFluentCombobox.razor Created a simple razor wrapper for the FixedFluentCombobox component.

Copy link
Member

@adamint adamint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but can you add a link in-code to the fluentui issue as well?

@JamesNK JamesNK enabled auto-merge (squash) April 1, 2025 01:43
@JamesNK JamesNK merged commit ad75817 into main Apr 1, 2025
172 checks passed
@JamesNK JamesNK deleted the jamesnk/fluentcombobox-fix branch April 1, 2025 02:29
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants