Skip to content

Use Copy Constructor for JsonSerializerSettings #61251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MatthewSteeples
Copy link

@MatthewSteeples MatthewSteeples commented Mar 31, 2025

Fixes #29532

Fixes an issue where JsonSerializerSettings.DateFormatString overwrites DateFormatHandling. See #29532 for details


For more details, open the Copilot Workspace session.

@MatthewSteeples MatthewSteeples requested a review from a team as a code owner March 31, 2025 22:23
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 31, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 31, 2025
@MatthewSteeples
Copy link
Author

@pranavkm the bot hasn't worked out who needs to review this and you were involved in the linked issue. Any chance you could nudge it in the right direction?

Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@halter73 halter73 enabled auto-merge (squash) April 4, 2025 23:32
auto-merge was automatically disabled April 6, 2025 11:52

Head branch was pushed to by a user without write access

@MatthewSteeples MatthewSteeples force-pushed the fix-json-serializer-settings branch 2 times, most recently from 11a8fe9 to 8a3cc91 Compare April 7, 2025 23:01
Fixes dotnet#29532

Fixes an issue where JsonSerializerSettings.DateFormatString overwrites DateFormatHandling. See dotnet#29532 for details
@MatthewSteeples MatthewSteeples force-pushed the fix-json-serializer-settings branch from fc4e126 to 7bac082 Compare April 8, 2025 22:13
@MatthewSteeples
Copy link
Author

I can't work out where the latest lot of build failures are coming from, so I'm hoping it's not me...!

Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
2 participants