-
Notifications
You must be signed in to change notification settings - Fork 10.3k
HttpNavigationManager
no longer uses NavigationException
#61306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0be84e4
Rise even instead of throwing.
ilonatommy 2e5f7dc
Clean up, delay not needed.
ilonatommy 5ebaaac
Fix typo + test old way of workign as well.
ilonatommy 1ea43be
Update name to be full namespace + remove readonly.
ilonatommy e9bd57e
Feedback - interactive SSR updates required exposing some methods.
ilonatommy ebc2537
Fix missing xml.
ilonatommy dff3c70
Fix build of tests.
ilonatommy 19d3fe9
Fix nullable.
ilonatommy def3e5c
Feedback - limit public API changes.
ilonatommy 9f79f51
Handle the case when response started.
ilonatommy e647f2a
Proposal of fixing external navigation.
ilonatommy 5e6d104
Update src/Components/test/testassets/Components.TestServer/RazorComp…
ilonatommy 8413a40
Merge branch 'main' into fix-59451
ilonatommy 9f7fceb
Merge branch 'fix-59451' of https://github.com/ilonatommy/aspnetcore …
ilonatommy aea9826
Feedback.
ilonatommy bafa937
More effective stopping of the renderer.
ilonatommy 3521c8f
POST cannot safely redirect like GET does, the body should be preserved.
ilonatommy a3ca937
Reuse the logic from navigation exception.
ilonatommy 5d7eb68
Editing the ongoing render batch is not possible - for non-streaming …
ilonatommy 69426fd
Missing change for the last commit.
ilonatommy e0b407c
Rename switch to match http and remote navigator.
ilonatommy dc45f3e
Adjust test for the new behavior.
ilonatommy b36db8b
Fix exception - driven navigation.
ilonatommy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this inside
https://github.com/dotnet/aspnetcore/blob/main/src/Components/Components/src/RenderTree/Renderer.cs#L736
which can be overriden byEndpointHtmlRenderer
and save ourselves having the public APISignalRendererToFinishRendering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do as you propose, the queue will keep being edited during the processing (line 676 below). That was why I added a new public API, to prevent new Enqueue() when we already sent the
stop
signal.