-
Notifications
You must be signed in to change notification settings - Fork 10.4k
IHttpRequestBodyDetectionFeature
for HTTP/3 GET requests
#62275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Updated `IHttpRequestBodyDetectionFeature` to include HTTP/3 descriptions for the `END_STREAM` flag. - Modified request body handling logic to return zero length content body instance when there endstream flag is set. It also completes the message body for empty requests, so that the RequestBodyPipe.Reader is closed (needed when stream is reused by the pool and the Pipe is reset). - Added unit test `CanHaveBody_ReturnsFalseWithoutRequestBody` to validate behavior when no request body is present.
|
@BrennanConroy - I will follow up on that. |
…der was not closed in http3) causing Reset to throw when stream was re-used.
@BrennanConroy I addressed your concern. |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
IHttpRequestBodyDetectionFeature
for HTTP/3 GET requestsIHttpRequestBodyDetectionFeature
returns false for HTTP/3 (bodyless) GET requestsDescription
IHttpRequestBodyDetectionFeature
to include HTTP/3 descriptions for theEND_STREAM
flag.Http3Stream
modified request body handling logic to return zero length content body instance when there endstream flag is set. It also completes the message body for empty requests, so that theRequestBodyPipe.Reader
is closed (needs to be closed, so that when the stream is reused by the pool, the Pipe is reset which requires closed reader) - not sure if this is the best place to do this.CanHaveBody_ReturnsFalseWithoutRequestBody
to validate behavior when no request body is present.Fixes #58753