Fixed race condition in the disposing of the QuickGrid

[dariatiurina]

Fixed race condition in the disposing of the QuickGrid

Description

This pull request introduces changes to improve the disposal logic of the QuickGrid component and adds new tests to ensure proper handling of race conditions during disposal. It also updates project files to include new test dependencies and internal visibility settings. Below is a summary of the most important changes:

Changes:

• Added a _disposeBool flag to the QuickGrid component to track its disposal state and prevent further operations if disposal is in progress.
• Updated the DisposeAsync method to set _disposeBool to true and ensure proper cleanup of resources.
• Modified the OnAfterRenderAsync method to check the _disposeBool flag and exit early if the component is being disposed while the JavaScript module is loading.
• Introduced a new test class, GridRaceConditionTest, to verify that the QuickGrid component can handle race conditions during disposal without errors. This includes simulating JavaScript interop behavior and rendering scenarios.
• Added InternalsVisibleTo for Microsoft.AspNetCore.Components.QuickGrid.Tests in the Microsoft.AspNetCore.Components.csproj file to allow internal access for testing purposes.
• Updated the Microsoft.AspNetCore.Components.QuickGrid.Tests.csproj file to include shared test helpers and dependencies for the new tests.

Fixes #47173

[wtgodbe]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).

[Copilot]

Pull Request Overview

This PR fixes a race condition in the QuickGrid component that could occur when the component is disposed while a JavaScript module is still being loaded. The fix adds a disposal flag to prevent JavaScript operations from executing after disposal has begun.

• Adds a _wasDisposed boolean flag to track disposal state and prevent operations after disposal
• Updates the disposal and rendering logic to handle race conditions gracefully
• Introduces comprehensive tests to verify the fix works and demonstrates the original problem

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
QuickGrid.razor.cs	Adds _wasDisposed flag and disposal race condition protection
GridRaceConditionTest.cs	New test class with comprehensive race condition testing
NotFailingQuickGrid.cs	Test helper component that uses the fixed QuickGrid implementation
FailingQuickGrid.cs	Test helper component that simulates the original race condition bug
Microsoft.AspNetCore.Components.csproj	Adds internal visibility for QuickGrid tests
Microsoft.AspNetCore.Components.QuickGrid.Tests.csproj	Includes shared test helpers

Comments suppressed due to low confidence (1)

src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.cs:156

• [nitpick] The field name _wasDisposed should be _disposeBool to match the variable name referenced in the PR description and test code, ensuring consistency across the codebase.

    private bool _wasDisposed;

[ilonatommy]

Great job!

Only a few clean-up updates.