Add QUERY to known HTTP methods in HostingMetrics#63276
Add QUERY to known HTTP methods in HostingMetrics#63276doominator42 wants to merge 1 commit intodotnet:mainfrom
Conversation
| KeyValuePair.Create(HttpMethods.Patch, HttpMethods.Patch), | ||
| KeyValuePair.Create(HttpMethods.Post, HttpMethods.Post), | ||
| KeyValuePair.Create(HttpMethods.Put, HttpMethods.Put), | ||
| KeyValuePair.Create(HttpMethods.Query, HttpMethods.Query), |
|
It looks like based on the linked discussion we need to put this in a holding pattern until the discussion in #62090 (review) is resolved. |
|
#62090 is now merged, I rebased my branch on top of it. For the OTEL semantics, according to open-telemetry/semantic-conventions#2642 (comment), adding methods known to the instrumentation is ok and since QUERY is now supported it would still follow conventions. Also, I did not find any tests specific to the known HTTP methods, should I just add new ones or this is good to go? |
|
/cc @JamesNK might be in your wheelhouse. Was added to SemConv by open-telemetry/semantic-conventions#2643 for v1.38.0. |
|
@halter73 Could we get your review on this? Would be good to get it merged sooner rather than later so we can do validation downstream in open-telemetry/opentelemetry-dotnet-contrib with preview builds. |
|
@doominator42 Would be good to add QUERY to this test: aspnetcore/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs Lines 1544 to 1560 in f7c186e |
|
Added tests and rebased on main |
As discussed in #61089 (comment), this PR is for adding
QUERYto the known HTTP methods for hosting metrics.