Skip to content

[Blazor] Clear RootTypeCache cache on HotReload #63549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

[Blazor] Clear RootTypeCache cache on HotReload #63549

merged 3 commits into from
Sep 12, 2025
+22 −1

Conversation

maraf
Copy link
Member

@maraf maraf commented Sep 4, 2025 •
edited
Loading

  • Clear RootTypeCache on HotReload.
  • The HotReloadManager.cs is now included in Components.Server & Components.WebAssembly as well.
  • The RootTypeCache implements IDisposable although at the moment all usages are "singleton".

Fixes #63286

@maraf maraf added this to the 11.0-preview1 milestone Sep 4, 2025
@maraf maraf self-assigned this Sep 4, 2025
@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 18:38
@maraf maraf added the area-blazor Includes: Blazor, Razor Components label Sep 4, 2025
@maraf maraf requested a review from a team as a code owner September 4, 2025 18:38
Copilot

This comment was marked as resolved.

Sign in to view

@maraf maraf marked this pull request as draft September 5, 2025 11:55
@maraf maraf marked this pull request as ready for review September 11, 2025 11:37
@maraf maraf requested a review from Copilot September 11, 2025 12:00
Copilot
Copilot AI reviewed Sep 11, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

This was referenced Sep 11, 2025
Open
Open
@maraf maraf merged commit 98dbdfd into main Sep 12, 2025
30 checks passed
@maraf maraf deleted the maraf/BlazorRootTypeCacheHotRealod branch September 12, 2025 10:03
@maraf
Copy link
Member Author

maraf commented Sep 12, 2025

/backport to release/10.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0: https://github.com/dotnet/aspnetcore/actions/runs/17671268495

@github-actions github-actions bot mentioned this pull request Sep 12, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@javiercn javiercn javiercn approved these changes

Assignees

@maraf maraf

Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
11.0-preview1
Development

Successfully merging this pull request may close these issues.

[Blazor] Missing cache clear on hot reload
2 participants
@maraf @javiercn