[Proposal] Analyzer test readability improvements #63642
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to suggest a couple of changes that can improve readability of code analyzer tests:
Use raw string literals for C# test source code in all unit tests for code analyzers.
I would suggest to apply
[StringSyntax("C#-test")]
to all helper methods used to run analyzer tests, for example:This should enable syntax highlighting for test C# source code in unit tests for analyzers. Currently the code in a test might look like this:
With raw string literals and
StringSyntax
attribute, this is what it will look like (I included such a test in #63641):Also VS draws a nice vertical line for raw string literals, which also means that there's no extra whitespace before the code so that it does not have to start from the very left overflowing the test.