Skip to content

[release/10.0] [Blazor] Clear RootTypeCache cache on HotReload #63653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/10.0
Choose a base branch
from
+22 −1
Open

[release/10.0] [Blazor] Clear RootTypeCache cache on HotReload #63653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a74fbb
Clear RootTypeCache cache on HotReload
maraf Sep 4, 2025
217018d
ClearCache method
maraf Sep 5, 2025
e755b75
Fix
maraf Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
</PropertyGroup>

<ItemGroup>
<Compile Include="$(ComponentsSharedSourceRoot)src\HotReloadManager.cs" LinkBase="HotReload" />
<Compile Include="$(ComponentsSharedSourceRoot)src\CacheHeaderSettings.cs" Link="Shared\CacheHeaderSettings.cs" />
<Compile Include="$(ComponentsSharedSourceRoot)src\ArrayBuilder.cs" LinkBase="Circuits" />
<Compile Include="$(ComponentsSharedSourceRoot)src\RenderBatchWriter.cs" LinkBase="Circuits" />
Expand Down
21 changes: 20 additions & 1 deletion src/Components/Shared/src/RootTypeCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.AspNetCore.Components.HotReload;
using System.Collections.Concurrent;
using System.Diagnostics.CodeAnalysis;
using System.Reflection;
Expand All @@ -12,10 +13,28 @@ namespace Microsoft.AspNetCore.Components;
#endif

// A cache for root component types
internal sealed class RootTypeCache
internal sealed class RootTypeCache : IDisposable
{
private readonly ConcurrentDictionary<Key, Type?> _typeToKeyLookUp = new();

public RootTypeCache()
{
if (HotReloadManager.Default.MetadataUpdateSupported)
{
HotReloadManager.Default.OnDeltaApplied += ClearCache;
}
}

internal void ClearCache() => _typeToKeyLookUp.Clear();

public void Dispose()
{
if (HotReloadManager.Default.MetadataUpdateSupported)
{
HotReloadManager.Default.OnDeltaApplied -= ClearCache;
}
}

public Type? GetRootType(string assembly, string type)
{
var key = new Key(assembly, type);
Expand Down
1 change: 1 addition & 0 deletions ...Components/WebAssembly/WebAssembly/src/Microsoft.AspNetCore.Components.WebAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
</ItemGroup>

<ItemGroup>
<Compile Include="$(ComponentsSharedSourceRoot)src\HotReloadManager.cs" LinkBase="HotReload" />
<Compile Include="$(ComponentsSharedSourceRoot)src\BrowserNavigationManagerInterop.cs" />
<Compile Include="$(ComponentsSharedSourceRoot)src\PullFromJSDataStream.cs" />
<Compile Include="$(ComponentsSharedSourceRoot)src\TransmitDataStreamToJS.cs" />
Expand Down
Loading