-
Notifications
You must be signed in to change notification settings - Fork 878
chore: Add support for .NET 10 target framework #10859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
81d6302 to
16b06df
Compare
yufeih
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @filzrev
|
Any chance to merge this and release yesterday? Thanks. 🙂 |
|
This PR intended to support for .NET 10 SDK and Roslyn 5.x. It need to additional tasks to generating HTML site that support for C# 14 features |
|
I see. For some reason, I can't build (SDK resolver issue) Stride docs (stride3d/stride-docs#430) with the latest (or previous) docfx version. I am targeting .NET 10 now and when I use your PR, it works 🙂. I will try docfx custom build with your PR merged temporarily, till this is merged and released 🤷♂️. |
1a9082c to
cb417da
Compare
|
Can this be merged and released, then add support for new language features later? I'm asking because building my codebase on .NET 10 currently doesn't work due to the following errors:
It's understandable that DocFX can't yet handle the new C# features, such as extension blocks and new conversion operators, because they affect the public API and require code changes that may take some time. This is why I'm postponing such changes in my codebase. So, if DocFX would only update to the latest Roslyn assemblies and release that, my problem would be solved, and I'm no longer blocked from releasing a .NET 10-compatible version. Edit: Well, I'm also dependent on #10850. |
This PR intended to add support for .NET 10.
net10.0toTargetFrameworks. (It increase NuGet package size)net8.0tonet10.0What's Changed in this PR
action.ymlactions/setup-nodeversionactions/setup-dotnetversionci.ymldotnet teststep for .NET 10.dotnet teststep for .NET 8 run on ubuntu only.lint.ymlactions/setup-dotnetstep.release.ymlactions/setup-dotnetsettings to install .NET 10Sign CLIversion and add comment. (It can'tdotnet nuget signcommand. and required to run on Windows)nightly.ymlsetup-dotnet(.NET 10 SDK is installed bysetup-dotnetstep instead)snapshot.ymldotnet testtarget framework to use .NET 10Directory.Build.Propsnet10.0target framework. (It's expected to increase NuGet package size)DOCFX_PREVIEW_BUILD(It's re-enabled when testing .NET 11)Directory.Packages.PropsSymbolFormatter.*.cs5.0.0*.csproj