Add all known unreleased Debian version codenames #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
reviewed
Jan 28, 2025
Comment on lines
180
to
210
| string s when s.Contains("debian") => "Debian", | ||
| string s when s.Contains("sid") => "Debian Unstable", | ||
| string s when s.Contains("jessie") => "Debian 8", | ||
| string s when s.Contains("stretch") => "Debian 9", | ||
| string s when s.Contains("buster") => "Debian 10", | ||
| string s when s.Contains("bullseye") => "Debian 11", | ||
| string s when s.Contains("bookworm") => "Debian 12", | ||
| string s when s.Contains("trixie") => "Debian 13", | ||
| string s when s.Contains("forky") => "Debian 14", | ||
| string s when s.Contains("duke") => "Debian 15", | ||
| string s when s.Contains("xenial") => "Ubuntu 16.04", | ||
| string s when s.Contains("bionic") => "Ubuntu 18.04", | ||
| string s when s.Contains("disco") => "Ubuntu 19.04", | ||
| string s when s.Contains("focal") => "Ubuntu 20.04", | ||
| string s when s.Contains("hirsute") => "Ubuntu 21.04", | ||
| string s when s.Contains("impish") => "Ubuntu 21.10", | ||
| string s when s.Contains("jammy") => "Ubuntu 22.04", | ||
| string s when s.Contains("noble") => "Ubuntu 24.04", | ||
| string s when s.Contains("azurelinux") => | ||
| FormatVersionableOsName(os, name => "Azure Linux"), | ||
| string s when s.Contains("cbl-mariner") => | ||
| FormatVersionableOsName(os, name => "CBL-Mariner"), | ||
| string s when s.Contains("leap") => | ||
| FormatVersionableOsName(os, name => "openSUSE Leap"), | ||
| string s when s.Contains("ubuntu") => | ||
| FormatVersionableOsName(os, name => "Ubuntu"), | ||
| string s when s.Contains("alpine") | ||
| || s.Contains("centos") | ||
| || s.Contains("fedora") => | ||
| FormatVersionableOsName(os, name => name.FirstCharToUpper()), | ||
| _ => throw new NotSupportedException($"The OS version '{os}' is not supported.") |
There was a problem hiding this comment.
I don't see a reason to keep around the legacy versions that we no longer (and will never) produce images for (e.g. Debian 9). There's also no need for sid as we'll never consume that version.
There was a problem hiding this comment.
Fair enough, I suppose we could get of everything up to and including bullseye (and impish for ubuntu)?
mthalman
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/dotnet-docker#6166.
This covers new Debian versions for approximately the next 6 years 👍
I also halved the number of lines in these methods by using switch expressions. Commits are separate so you can easily see exactly what I added.