Skip to content

Add image/layer size to image-info and ingest in Kusto #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 24, 2025

Conversation

lbussell
Copy link
Contributor

Fixes #745

@lbussell lbussell requested a review from a team as a code owner February 21, 2025 23:09
@lbussell lbussell changed the title Ingest image/layer size in Kusto Add image/layer size to image-info and ingest in Kusto Feb 21, 2025
@lbussell
Copy link
Contributor Author

It has occurred to me that we might need to bootstrap this somehow. Since we changed the image-info model, the new version of ImageBuilder probably won't be able to deserialize any current image-info.json files.

@lbussell
Copy link
Contributor Author

lbussell commented Feb 24, 2025

At the same time, we'd need to update all image-infos and ImageBuilder versions at once, since the docker-tools repo handles queueing rebuilds and downstream repos handle publishing the image infos.

It might be better to update the model to support reading both the old and new models (list of string vs. list of Layer objects).

@lbussell lbussell added the do-not-merge A PR that should not be merged yet but needs to remain open label Feb 25, 2025
@lbussell
Copy link
Contributor Author

lbussell commented Feb 27, 2025

I think the correct approach for this would be to increment the SchemaVersion on ImageArtifactDetails:

public class ImageArtifactDetails
{
public string SchemaVersion
{
get { return "1.0"; }
set { }
}

Then I think we'd implement a custom JsonConverter for either ImageArtifactDetails or PlatformInfo. When we encounter a "1.0" SchemaVersion we'd convert it to the new format. Need to think about it some more!

@lbussell lbussell marked this pull request as draft March 6, 2025 22:38
@lbussell lbussell force-pushed the add-layer-size-ingestion-f10 branch from 00f8d04 to 6f4ed0d Compare April 23, 2025 20:10
@lbussell lbussell marked this pull request as ready for review April 23, 2025 20:11
@lbussell lbussell merged commit fc303cd into dotnet:main Apr 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge A PR that should not be merged yet but needs to remain open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest image/layer size in Kusto
2 participants