-
Notifications
You must be signed in to change notification settings - Fork 60
Add image/layer size to image-info and ingest in Kusto #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.DotNet.ImageBuilder/src/Commands/IngestKustoImageInfoCommand.cs
Show resolved
Hide resolved
It has occurred to me that we might need to bootstrap this somehow. Since we changed the image-info model, the new version of ImageBuilder probably won't be able to deserialize any current image-info.json files. |
At the same time, we'd need to update all image-infos and ImageBuilder versions at once, since the docker-tools repo handles queueing rebuilds and downstream repos handle publishing the image infos. It might be better to update the model to support reading both the old and new models (list of string vs. list of Layer objects). |
I think the correct approach for this would be to increment the SchemaVersion on ImageArtifactDetails: docker-tools/src/Microsoft.DotNet.ImageBuilder/src/Models/Image/ImageArtifactDetails.cs Lines 9 to 15 in 71f2d6a
Then I think we'd implement a custom JsonConverter for either |
00f8d04
to
6f4ed0d
Compare
Fixes #745