feat: add Hosting.MailPit docs for the pr under CommunityToolkit #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@dotnet-policy-service agree |
IEvangelist
approved these changes
Mar 27, 2025
Comment on lines
+80
to
+82
| var mailpit = builder.AddMailPit("mailpit") | ||
| .WithDataBindMount( | ||
| source: @"C:\MailPit\Data"); |
There was a problem hiding this comment.
Suggested change
| var mailpit = builder.AddMailPit("mailpit") | |
| .WithDataBindMount( | |
| source: @"C:\MailPit\Data"); | |
| var mailpit = builder.AddMailPit("mailpit") | |
| .WithDataBindMount(source: @"C:\MailPit\Data"); |
| Data bind mounts rely on the host machine's filesystem to persist the MailPit data across container restarts. The data bind mount is mounted at the `C:\MailPit\Data` on Windows (or `/MailPit/Data` on Unix) path on the host machine in the MailPit container. For more information on data bind mounts, see [Docker docs: Bind mounts](https://docs.docker.com/engine/storage/bind-mounts). | ||
|
|
||
| ## Client integration | ||
|
|
There was a problem hiding this comment.
Suggested change
| There isn't a Community Toolkit client integration, however, if you're consuming the resource, it's good to know how to configure your clients. | |
IEvangelist
reviewed
Mar 27, 2025
There was a problem hiding this comment.
This article needs to be added to the TOC, under here: https://github.com/dotnet/docs-aspire/blob/main/docs/toc.yml#L289
IEvangelist
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds supporting documentation for the MailPit hosting integration in the Community Toolkit tracked by CommunityToolkit/Aspire#476
Internal previews