Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure SignalR Service content rewrite #2775

Merged
merged 10 commits into from
Mar 26, 2025
Merged

Azure SignalR Service content rewrite #2775

merged 10 commits into from
Mar 26, 2025

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Mar 6, 2025 •
edited by github-actions bot
Loading

Summary

[Draft]: Azure SignalR Service content rewrite

Fixes #2316

Internal previews

📄 File 🔗 Preview link
docs/real-time/azure-signalr-scenario.md .NET Aspire Azure SignalR Service integration

@IEvangelist IEvangelist changed the title Signalr rewrite Azure SignalR Service content rewrite Mar 6, 2025
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-health KR: Concerns article defects/freshness or build warnings. label Mar 6, 2025
@IEvangelist IEvangelist marked this pull request as ready for review March 7, 2025 20:48
@IEvangelist IEvangelist requested review from adegeo and vicancy March 7, 2025 20:48
@davidfowl
Copy link
Member

@vicancy

vicancy
vicancy reviewed Mar 17, 2025
View reviewed changes
adegeo
adegeo reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock. I think I have some good feedback here, but as always, choose what makes sense and dismiss the others 🐶

adegeo
adegeo approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep forgetting to click the approve option... ugh

@IEvangelist @adegeo
Apply suggestions from code review
b52e248 
Co-authored-by: Andy (Steve) De George <[email protected]>
@IEvangelist IEvangelist merged commit 8d9abb8 into dotnet:main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicancy vicancy vicancy left review comments

@adegeo adegeo adegeo approved these changes

Assignees
No one assigned
Labels
okr-quality Content-health KR: Concerns article defects/freshness or build warnings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite of the Azure SignalR Service integration article
4 participants
@IEvangelist @davidfowl @vicancy @adegeo