Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document MSTEST0039 and MSTEST0040 #44419

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Document MSTEST0039 and MSTEST0040 #44419

merged 5 commits into from
Jan 22, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 17, 2025 •
edited by github-actions bot
Loading

Fixes microsoft/testfx#4691
Fixes microsoft/testfx#4690

cc @Evangelink

Internal previews

📄 File 🔗 Preview link
docs/core/testing/mstest-analyzers/mstest0035.md MSTEST0035: [DeploymentItem] can be specified only on test class or test method
docs/core/testing/mstest-analyzers/mstest0036.md "MSTEST0036: Do not use shadowing inside test class."
docs/core/testing/mstest-analyzers/mstest0037.md MSTEST0037: Use proper 'Assert' methods
docs/core/testing/mstest-analyzers/mstest0038.md MSTEST0038: Don't use 'Assert.AreSame' or 'Assert.AreNotSame' with value types
docs/core/testing/mstest-analyzers/mstest0039.md docs/core/testing/mstest-analyzers/mstest0039
docs/core/testing/mstest-analyzers/mstest0040.md MSTEST0040: Do not assert inside 'async void' contexts
docs/core/testing/mstest-analyzers/usage-rules.md MSTest Usage rules (code analysis)
docs/navigate/devops-testing/toc.yml docs/navigate/devops-testing/toc

@Youssef1313 Youssef1313 requested review from IEvangelist and a team as code owners January 17, 2025 18:03
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 17, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 17, 2025
@Youssef1313 Youssef1313 mentioned this pull request Jan 18, 2025
Open
@BillWagner
Copy link
Member

This LGTM. @gewarren Do you want to take a look?

gewarren
gewarren approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions. Thanks for adding these.

docs/core/testing/mstest-analyzers/mstest0039.md Outdated Show resolved Hide resolved
docs/core/testing/mstest-analyzers/mstest0039.md Outdated Show resolved Hide resolved
docs/core/testing/mstest-analyzers/mstest0039.md Outdated Show resolved Hide resolved
docs/core/testing/mstest-analyzers/mstest0040.md Outdated Show resolved Hide resolved
@Youssef1313 @gewarren
Apply suggestions from code review
7d5a321 
Co-authored-by: Genevieve Warren <[email protected]>
@BillWagner BillWagner merged commit 295d55a into dotnet:main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@gewarren gewarren gewarren approved these changes

@Evangelink Evangelink Evangelink approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2025
5 participants
@Youssef1313 @BillWagner @stephentoub @Evangelink @gewarren