Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Fix build suggestions 1/28 #44582

Merged
merged 3 commits into from
Jan 29, 2025
Merged

[Chore] Fix build suggestions 1/28 #44582

merged 3 commits into from
Jan 29, 2025

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 28, 2025 •
edited by github-actions bot
Loading

@gewarren gewarren requested review from a team, IEvangelist and nishanil as code owners January 28, 2025 21:37
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 28, 2025
BillWagner
BillWagner approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren enabled auto-merge (squash) January 29, 2025 15:43
@gewarren gewarren merged commit e6f894d into dotnet:main Jan 29, 2025
8 checks passed
@gewarren gewarren deleted the build-warnings branch January 29, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

@nishanil nishanil Awaiting requested review from nishanil nishanil is a code owner

Assignees
No one assigned
Labels
dotnet-architecture/svc dotnet-azure/svc microservices/subsvc
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner