Skip to content

Add known pitfalls to the article of nullable warnings and include 'Constructors` section in it. #44985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Feb 21, 2025

This pull request closes #44184

It adds a note regarding the known pitfalls of nullable warning not always being issued and adds the example (well presented by the issue's author) to that "Known pitfalls" section as a "Constructors" case.


Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/compiler-messages/nullable-warnings.md Resolve nullable warnings
docs/csharp/nullable-references.md Nullable reference types

@BartoszKlonowski BartoszKlonowski requested review from BillWagner and a team as code owners February 21, 2025 16:08
@dotnetrepoman dotnetrepoman bot added this to the February 2025 milestone Feb 21, 2025
@dotnet-policy-service dotnet-policy-service bot added okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. dotnet-csharp/svc lang-reference/subsvc csharp-diagnostics/subsvc community-contribution Indicates PR is created by someone from the .NET community. labels Feb 21, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @BartoszKlonowski

I had a few comments, and then this is ready.

@BartoszKlonowski BartoszKlonowski force-pushed the fix/44184/missing-compilation-null-reference-warning branch from b76c412 to 3bd3174 Compare February 21, 2025 17:31
@BillWagner
Copy link
Member

I think the build error has been addressed. Closing & Reopening to check.

@BillWagner BillWagner closed this Feb 21, 2025
@BillWagner BillWagner reopened this Feb 21, 2025
@BartoszKlonowski
Copy link
Contributor Author

I think the build error has been addressed. Closing & Reopening to check.

I saw that there are two files that are included in the check and that have warnings in them. artificial-intelligence.md and ai-extensions.md. There's a note that it may happen at times that other files will be included, but I can't access the linked instruction on how to deal with such scenario, so I will count on your help, @BillWagner 🙏

@BillWagner BillWagner closed this Feb 21, 2025
@BillWagner BillWagner reopened this Feb 21, 2025
@BartoszKlonowski BartoszKlonowski force-pushed the fix/44184/missing-compilation-null-reference-warning branch from 4e806e6 to 1a11dd2 Compare February 22, 2025 02:05
@BillWagner BillWagner enabled auto-merge (squash) February 24, 2025 16:44
@BillWagner BillWagner merged commit 95e3b6e into dotnet:main Feb 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. csharp-diagnostics/subsvc dotnet-csharp/svc lang-reference/subsvc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing a compilation null reference warning for a particular case.
2 participants