-
Notifications
You must be signed in to change notification settings - Fork 6k
Add known pitfalls to the article of nullable warnings and include 'Constructors` section in it. #44985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add known pitfalls to the article of nullable warnings and include 'Constructors` section in it. #44985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @BartoszKlonowski
I had a few comments, and then this is ready.
docs/csharp/language-reference/compiler-messages/nullable-warnings.md
Outdated
Show resolved
Hide resolved
b76c412
to
3bd3174
Compare
I think the build error has been addressed. Closing & Reopening to check. |
I saw that there are two files that are included in the check and that have warnings in them. |
Co-authored-by: Bill Wagner <[email protected]>
Co-authored-by: Bill Wagner <[email protected]>
4e806e6
to
1a11dd2
Compare
This pull request closes #44184
It adds a note regarding the known pitfalls of nullable warning not always being issued and adds the example (well presented by the issue's author) to that "Known pitfalls" section as a "Constructors" case.
Internal previews