Skip to content

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 7, 2026

Contributes to dotnet/docs#50894.

Copilot AI review requested due to automatic review settings January 7, 2026 23:22
@gewarren gewarren requested a review from a team as a code owner January 7, 2026 23:22
@gewarren gewarren requested a review from tarekgh January 7, 2026 23:22
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the JapaneseCalendar documentation and code examples to reflect the new minimum supported date for .NET 11. The minimum supported date changes from September 8, 1868 to October 23, 1868 C.E. in the Gregorian calendar.

Key changes:

  • Updated MinSupportedDateTime property documentation to specify October 23, 1868 as the new minimum date for .NET 11
  • Added version notes clarifying the date difference between .NET 10 and earlier versus .NET 11
  • Removed ?displayProperty=nameWithType from various xref property references for cleaner formatting
  • Modernized C# code examples to use top-level statements and target constructors
  • Reformatted and updated code snippet output to reflect the new dates

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
xml/System.Globalization/JapaneseCalendar.xml Updated MinSupportedDateTime documentation, added version notes, cleaned up xref formatting, and corrected whitespace
snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.cs Modernized code to top-level statements, updated expected output for .NET 11 with new minimum date
snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.csproj Changed output type to Exe and target framework to net10.0
snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.vb Reformatted code, updated expected output for .NET 11 with new minimum date
snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.vbproj Added new project file targeting net10.0 with Exe output type

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gewarren

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, once you address the open conversations.

@gewarren gewarren enabled auto-merge (squash) January 8, 2026 23:01
@gewarren gewarren merged commit f4db748 into dotnet:main Jan 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants