-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update minimum supported date for .NET 11 #12207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the JapaneseCalendar documentation and code examples to reflect the new minimum supported date for .NET 11. The minimum supported date changes from September 8, 1868 to October 23, 1868 C.E. in the Gregorian calendar.
Key changes:
- Updated
MinSupportedDateTimeproperty documentation to specify October 23, 1868 as the new minimum date for .NET 11 - Added version notes clarifying the date difference between .NET 10 and earlier versus .NET 11
- Removed
?displayProperty=nameWithTypefrom various xref property references for cleaner formatting - Modernized C# code examples to use top-level statements and target constructors
- Reformatted and updated code snippet output to reflect the new dates
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| xml/System.Globalization/JapaneseCalendar.xml | Updated MinSupportedDateTime documentation, added version notes, cleaned up xref formatting, and corrected whitespace |
| snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.cs | Modernized code to top-level statements, updated expected output for .NET 11 with new minimum date |
| snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.csproj | Changed output type to Exe and target framework to net10.0 |
| snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.vb | Reformatted code, updated expected output for .NET 11 with new minimum date |
| snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.vbproj | Added new project file targeting net10.0 with Exe output type |
...lbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.vb
Show resolved
Hide resolved
snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.csproj
Show resolved
Hide resolved
snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.vbproj
Show resolved
Hide resolved
tarekgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gewarren
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, once you address the open conversations.
Contributes to dotnet/docs#50894.