Skip to content

Allow to add and delete dependents sharing a table #17951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

AndriySvyryd
Copy link
Member

Description

Modifications to a shared row will derive their state only from the main entry (the entry that isn't a dependent of any other entry in the row). If the main entry isn't present the row is assumed to be modified.
The principal entry is now not required to be in the same state as the dependent when saving changes to a shared row.

Fixes #17422
Fixes #17935

Customer impact

Allows to add and delete just the dependent entities when using table splitting.

Regression

No, optional dependents in table splitting is a new feature in 3.0

Risk

Medium, can impact other update scenarios.

@AndriySvyryd
Copy link
Member Author

Ping. I'd like to push this in today.

…entry (the entry that isn't a dependent of any other entry in the row). If the main entry isn't present the row is assumed to be modified.

The principal entry is now not required to be in the same state as the dependent when saving changes to a shared row.

Fixes #17422
Fixes #17935
@AndriySvyryd AndriySvyryd merged commit 4ca164e into release/3.1 Sep 25, 2019
@ghost ghost deleted the Issue17422 branch September 25, 2019 12:44
@Neme12
Copy link

Neme12 commented Nov 1, 2019

@AndriySvyryd

Regression

No, optional dependents in table splitting is a new feature in 3.0

Yes, this is a regression. The fact that they're optional is a new feature, but there's no way to opt out of that. In EF Core 2.2, I didn't use to get null for an owned entity, but now I do and there's nothing I can do to change that. Owned entity types are now completely unusable. 😞 Can you please consider backporting this to 3.0?

@AndriySvyryd
Copy link
Member Author

@Neme12 There's no point fixing this in 3.0.x as that version would be released at the same time as 3.1.0. Use the preview version to unblock yourself.

@Neme12
Copy link

Neme12 commented Nov 1, 2019

@AndriySvyryd But that requires not only a new version of EF Core, but also .NET Core which 1) has to be installed on the production server and 2) requires a new SDK (one that doesn't come with VS) which other devs won't want to install.

@AndriySvyryd
Copy link
Member Author

@Neme12 EF Core 3.1 should work on .NET Core 3.0 and 3.0.x SDK

@Neme12
Copy link

Neme12 commented Nov 2, 2019

@AndriySvyryd Thanks, it does! What confused me was the fact that I didn't get completion for that version number in VS. I filed an issue here: dotnet/ProjFileTools#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants