Update to latest dotnet SDK and comment out non-compiling tests #35569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as it's ambiguous with the once introduced into .NET
Because of the new .NET Contains overload with an optional parameter, which is incompatible with LINQ expression trees. See dotnet#35547
cincuranet
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the dotnet SDK to the latest current daily build (10.0.100-preview.2.25081.1), and importantly, comments out tests that no longer compile because of the new Contains() overload introduced into .NET (dotnet/runtime#110197), tracked on the EF side by #35547.
The commenting out is (hopefully) very temporary, until the problem is resolved on the .NET/compiler side and we can uncomment them back again. But this allows us to continue using the latest SDKs in the meantime.