[rc2] Stop transforming complex property access to EF.Property #36786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
roji
force-pushed
the
ComplexEfProperty
branch
from
3aee44f to
047037f
Compare
roji
force-pushed
the
ComplexEfProperty
branch
from
047037f to
83a0a11
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
cincuranet
approved these changes
Sep 16, 2025
cincuranet
added a commit
that referenced
this pull request
Sep 17, 2025
* Update dependencies from https://github.com/dotnet/dotnet build 283422 Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 10.0.0-beta.25464.104 -> 10.0.0-beta.25466.101) Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 10.0.0-rc.2.25464.104 -> 10.0.0-rc.2.25466.101) * [rc2] Fix race condition in SingletonCosmosClientWrapper.Client (#36767) Fixes #36714 Co-authored-by: AndriySvyryd <[email protected]> * Fix ExecuteUpdate parameters for multiple properties with same name (#36792) And validate against null required properties in JSON serialization. Fixes #36791 * Stop transforming complex property access to EF.Property (#36786) Fixes #36761 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Jiri Cincura ↹ <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: AndriySvyryd <[email protected]> Co-authored-by: Shay Rojansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36761
Description
As part of the considerable work that went into complex types in 10, complex property accesses in queries started getting systematically transformed into EF.Property, as (was) standard in the query pipeline. This causes query failure when an unmapped property access is composed on top.
Customer impact
Queries accessing unmapped properties via complex properties now fail:
How found
Customer reported.
Regression
Yes
Testing
Test added
Risk
Low, affects mainly new code introduced in EF 10, and in any case only complex type support, which was very limited before 10 and so doesn't risk breaking many people.