Skip to content

Fix PMC commands failing on build warnings in VS 2026 #37673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 7 commits into from
Feb 12, 2026
+13 −1
Merged

Fix PMC commands failing on build warnings in VS 2026 #37673

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a934f3
Initial plan
Copilot Feb 11, 2026
60c481b
Fix Package Manager Console ErrorActionPreference regression with bui…
Copilot Feb 11, 2026
055c68d
Preserve original ErrorActionPreference value in build wrapper
Copilot Feb 11, 2026
54209d0
Only change ErrorActionPreference if it was 'Stop'
Copilot Feb 11, 2026
c59020c
Apply ErrorActionPreference handling to dotnet build calls
Copilot Feb 11, 2026
3e9bdd7
Revert ErrorActionPreference handling for $solutionBuild.Build(), kee…
Copilot Feb 11, 2026
acb9e76
Update src/EFCore.Tools/tools/EntityFrameworkCore.psm1
AndriySvyryd Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/EFCore.Tools/tools/EntityFrameworkCore.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,7 +1258,19 @@ function EF($project, $startupProject, $params, $applicationArgs, [switch] $skip

# TODO: Only build startup project. Don't use BuildProject, you can't specify platform
$solutionBuild = $DTE.Solution.SolutionBuild
$solutionBuild.Build(<# WaitForBuildToFinish: #> $true)
$previousErrorActionPreference = $ErrorActionPreference
try
{
if ($ErrorActionPreference -eq 'Stop')
{
$ErrorActionPreference = 'Continue'
}
$solutionBuild.Build(<# WaitForBuildToFinish: #> $true)
}
finally
{
$ErrorActionPreference = $previousErrorActionPreference
}
if ($solutionBuild.LastBuildInfo)
{
throw 'Build failed.'
Expand Down Expand Up @@ -1399,7 +1411,19 @@ function EF($project, $startupProject, $params, $applicationArgs, [switch] $skip
}

# NB: -join is here to support ConvertFrom-Json on PowerShell 3.0
$references = (dotnet build $startupProject.FullName /t:ResolvePackageAssets /getItem:RuntimeCopyLocalItems) -join "`n" | ConvertFrom-Json
$previousErrorActionPreference = $ErrorActionPreference
try
{
if ($ErrorActionPreference -eq 'Stop')
{
$ErrorActionPreference = 'Continue'
}
$references = (dotnet build $startupProject.FullName /t:ResolvePackageAssets /getItem:RuntimeCopyLocalItems) -join "`n" | ConvertFrom-Json
}
finally
{
$ErrorActionPreference = $previousErrorActionPreference
}

$designReference = $references.Items.RuntimeCopyLocalItems | ? { $_.FullPath.EndsWith('Microsoft.EntityFrameworkCore.Design.dll') }
if ($designReference -ne $null)
Expand Down
Loading