Skip to content

Update ILLink.Substitutions.xml #14395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update ILLink.Substitutions.xml #14395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92cabb0
Update ILLink.Substitutions.xml
vzarytovskii Nov 28, 2022
1d24136
Merge branch 'main' into vzarytovskii-patch-10
KevinRansom Dec 1, 2022
bbbd2e4
Merge branch 'main' into vzarytovskii-patch-10
vzarytovskii May 25, 2023
cfd33ae
Disable compressed trimming test
vzarytovskii May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,8 +628,10 @@ stages:
strategy:
maxParallel: 2
matrix:
compressed_metadata:
_kind: "-compressAllMetadata"
# We've disabled trimming metadata for FSharp.Core, due to the issue in linker, when it produces the warning if resource does not exist.
# Publicly shipped FSHarp.Core (nuget) contains only uncompressed metadata.
#compressed_metadata:
# _kind: "-compressAllMetadata"
classic_metadata:
_kind: ""
variables:
Expand Down
5 changes: 4 additions & 1 deletion src/FSharp.Core/ILLink.Substitutions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<linker>
<assembly fullname="FSharp.Core">
<!-- TODO: Disabling compressed resources until we produce those for FSharp.Core.
Trimming something which does not exist in the DLL causes linker to fail in runtime repo:
https://github.com/dotnet/runtime/pull/78034#issuecomment-1328705849
<resource name="FSharpOptimizationCompressedData.FSharp.Core" action="remove" />
<resource name="FSharpSignatureCompressedData.FSharp.Core" action="remove" /> -->
<resource name="FSharpOptimizationInfo.FSharp.Core" action="remove" />
<resource name="FSharpSignatureCompressedData.FSharp.Core" action="remove" />
<resource name="FSharpSignatureInfo.FSharp.Core" action="remove" />
</assembly>
</linker>