Skip to content

FSharp.Core: Add Async.RunImmediate(Async<'T>, CancellationToken) #14532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

FSharp.Core: Add Async.RunImmediate(Async<'T>, CancellationToken) #14532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bb73d2
FSharp.Core: Add Async.Runimmediate(Async<'T>, CancellationToken)
vzarytovskii Jan 2, 2023
67e98b3
Fantomas
vzarytovskii Jan 2, 2023
36d1469
Reuse existing runimmediate via ResultCell<AsyncResult<_>> instead of…
vzarytovskii Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/FSharp.Core/async.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,6 +1501,10 @@ type Async =

computation.Invoke newCtxt)

static member RunImmediate(computation: Async<'T>, ?cancellationToken: CancellationToken) =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be preview right?

fsharp/src/FSharp.Core/prim-types.fsi

Line 2571 in bc88b51

[<Experimental("Experimental library feature, requires '--langversion:preview'")>]

let cancellationToken = defaultArg cancellationToken Async.DefaultCancellationToken
AsyncPrimitives.RunImmediate cancellationToken computation

Comment on lines +1504 to +1507
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ResultCell version here instead of TCS

static member RunSynchronously(computation: Async<'T>, ?timeout, ?cancellationToken: CancellationToken) =
let timeout, cancellationToken =
match cancellationToken with
Expand Down
Loading