Use correct TFM for source build when OfficialBuildId isn't set #18397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mthalman
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Mar 21, 2025
KevinRansom
approved these changes
Mar 25, 2025
T-Gro
added a commit
that referenced
this pull request
Mar 26, 2025
* Use correct TFM for source build when OfficialBuildId isn't set (#18397) * Update dependencies coming from maintenance-packages (#18329) * Update dependencies coming from maintenance-packages * Remove temp feed * Sort * Push for real the changes this time * Update to latest in nuget.org * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250320.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.25163.3 -> To Version 9.0.0-alpha.1.25170.3 * Bring back conditions * missing space --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> --------- Co-authored-by: Matt Thalman <[email protected]> Co-authored-by: Carlos Sánchez López <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Tomas Grosup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/source-build#4855
When building fsharp in source build without having
OfficialBuildIdset, it ends up using the default TFM ofnet9.0for the FSharp.Compiler.Service project. This causes a failure because source build uses the latest TFM,net10.0currently:System.Collections.Immutable 10.0.0-preview.2.25160.1 doesn't support net9.0 and has not been tested with it. Consider upgrading your TargetFramework to net10.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.This is caused by an incorrect property being used for setting
TargetFrameworkswhenOfficialBuildIdisn't set for the FSharp.Compiler.Service project. It's configured to useFSharpNetCoreProductDefaultTargetFramework, which is always hardcoded:fsharp/Directory.Build.props
Line 9 in 3259edf
Instead, it should use
FSharpNetCoreProductTargetFramework, which will be set toFSharpNetCoreProductDefaultTargetFrameworkunless source build is being used when it'll be set toNetCurrent:fsharp/Directory.Build.props
Lines 75 to 90 in 3259edf