Remove a bunch of files from fantomas ignore

.fantomasignore

@@ -40,19 +40,6 @@ src/Compiler/Checking/SignatureConformance.fs
 src/Compiler/Checking/TypeHierarchy.fs
 src/Compiler/Checking/TypeRelations.fs
 
-# nullness-related problems
-src/Compiler/Utilities/lib.fsi
-src/Compiler/Utilities/Cancellable.fsi
-src/FSharp.Core/tasks.fsi
-src/FSharp.Core/tasks.fs
-src/FSharp.Core/resumable.fs
-src/Compiler/DependencyManager/DependencyProvider.fs
-src/FSharp.Core/fslib-extra-pervasives.fs
-src/FSharp.Core/fslib-extra-pervasives.fsi
-
-# Incorrectly formatted: https://github.com/dotnet/fsharp/pull/14645/commits/49443a67ea8a17670c8a7c80c8bdf91f82231e91 or https://github.com/fsprojects/fantomas/issues/2733
-# This CompilerImports.fs behavior is not fixed yet, following up in  https://github.com/fsprojects/fantomas/issues/2733
-src/Compiler/Driver/CompilerImports.fs
 # The following files were formatted, but the "format, --check" loop is not stable.
 # Fantomas formats them, but still thinks they need formatting
 src/Compiler/Optimize/DetupleArgs.fs
@@ -96,44 +83,6 @@ src/FSharp.Core/printf.fs
 src/FSharp.Core/Query.fs
 src/FSharp.Core/seqcore.fs
 
-
-# fsharp  (to investigate)
-
-**/TypeProviders.fsi
-**/tainted.fsi
-
-# uses nullness features
-
-**/DependencyProvider.fsi
-src/FSharp.Core/array.fs
-src/FSharp.Core/option.fsi
-src/FSharp.Core/option.fs
-src/fsi/console.fs
-src/FSharp.Build/FSharpCommandLineBuilder.fs
-
-src/Compiler/Utilities/Activity.fs
-src/Compiler/Utilities/sformat.fs
-src/Compiler/Utilities/illib.fsi
-src/Compiler/Utilities/illib.fs
-
-
-src/Compiler/Utilities/NullnessShims.fs
-src/Compiler/Utilities/DependencyGraph.fs
-src/Compiler/Utilities/LruCache.fsi
-src/Compiler/Utilities/LruCache.fs
-src/Compiler/Utilities/HashMultiMap.fsi
-src/Compiler/Utilities/HashMultiMap.fs
-src/Compiler/Facilities/AsyncMemoize.fsi
-src/Compiler/Facilities/AsyncMemoize.fs
-src/Compiler/AbstractIL/il.fs
-src/Compiler/SyntaxTree/LexerStore.fs
-
-src/Compiler/Driver/GraphChecking/Graph.fsi
-src/Compiler/Driver/GraphChecking/Graph.fs
-
-src/Compiler/DependencyManager/NativeDllResolveHandler.fsi
-src/Compiler/DependencyManager/AssemblyResolveHandler.fsi
-
 # Fantomas limitations on implementation files  (to investigate)
 
 src/Compiler/AbstractIL/ilwrite.fs

Directory.Build.props

@@ -62,7 +62,7 @@
          since it's a non-arcade and non-sourcebuild scenario -->
     <FsLexPath>$(ArtifactsDir)/bin/fslex/$(Configuration)/$(FSharpNetCoreProductDefaultTargetFramework)/$(RuntimeIdentifier)/fslex.dll</FsLexPath>
     <FsYaccPath>$(ArtifactsDir)/bin/fsyacc/$(Configuration)/$(FSharpNetCoreProductDefaultTargetFramework)/$(RuntimeIdentifier)/fsyacc.dll</FsYaccPath>
-    <DefineConstants>NO_CHECKNULLS;BUILDING_WITH_LKG;NO_NULLCHECKING_LIB_SUPPORT;$(DefineConstants)</DefineConstants>
+    <DefineConstants>BUILDING_WITH_LKG;$(DefineConstants)</DefineConstants>
   </PropertyGroup>
 
   <Import Project="$(MSBuildThisFileDirectory)/eng/Versions.props" Condition="'$(DISABLE_ARCADE)' == 'true'" />

FSharp.Profiles.props

@@ -1,41 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information. -->
 <Project>
-  <PropertyGroup>
-    <!-- This turns on/off the use of the feature within the codebase -->
-    <!-- The default is off - it is selectively enabled -->
-    <CheckNulls Condition="'$(CheckNulls)' == ''">false</CheckNulls>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(FSHARPCORE_USE_PACKAGE)' == 'true'">
-    <!-- nullness checking isn't possible when using shipped FSharp.Core package until it's updated -->
-    <CheckNulls>false</CheckNulls>
-  </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)' == 'Proto'">
-    <CheckNulls>false</CheckNulls>
-    <DefineConstants>NO_CHECKNULLS;BUILDING_WITH_LKG;NO_NULLCHECKING_LIB_SUPPORT;$(DefineConstants)</DefineConstants>
-    <NullCheckingSupportInLibrary>false</NullCheckingSupportInLibrary>
+    <DefineConstants>BUILDING_WITH_LKG;$(DefineConstants)</DefineConstants>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)' != 'Proto' and '$(BUILDING_USING_DOTNET)' != 'true' and '$(MSBuildProjectExtension)' == '.fsproj'"> <!-- VB.NET does not understand "preview". It only knows "old","older" and "boomer" :-)) (jk)-->
     <LangVersion>preview</LangVersion>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(BUILDING_USING_DOTNET)' == 'true'"> 
-      <CheckNulls>false</CheckNulls>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(CheckNulls)' == 'true'">
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(CheckNulls)' == 'false'">
-    <!-- 3271: warning nullness annotations being ignored -->
-    <NoWarn>$(NoWarn);3271</NoWarn>
-    <DefineConstants>NO_CHECKNULLS;$(DefineConstants)</DefineConstants>
-  </PropertyGroup>
-
   <Choose>
     <When Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' ">
     </When>

src/Compiler/AbstractIL/il.fs

@@ -170,11 +170,8 @@ let splitTypeNameRight nm =
 // --------------------------------------------------------------------
 
 /// This is used to store event, property and field maps.
-type LazyOrderedMultiMap<'Key, 'Data when 'Key: equality
-#if !NO_CHECKNULLS
-    and 'Key:not null
-#endif
-    >(keyf: 'Data -> 'Key, lazyItems: InterruptibleLazy<'Data list>) =
+type LazyOrderedMultiMap<'Key, 'Data when 'Key: equality and 'Key: not null>(keyf: 'Data -> 'Key, lazyItems: InterruptibleLazy<'Data list>)
+    =
 
     let quickMap =
         lazyItems
@@ -519,7 +516,11 @@ type ILAssemblyRef(data) =
 
         let retargetable = aname.Flags = AssemblyNameFlags.Retargetable
 
-        let name = match aname.Name with | null -> aname.FullName | name -> name
+        let name =
+            match aname.Name with
+            | null -> aname.FullName
+            | name -> name
+
         ILAssemblyRef.Create(name, None, publicKey, retargetable, version, locale)
 
     member aref.QualifiedName =
@@ -1862,7 +1863,7 @@ type ILGenericParameterDef =
         Name: string
         Constraints: ILTypes
         Variance: ILGenericVariance
-        HasReferenceTypeConstraint: bool        
+        HasReferenceTypeConstraint: bool
         HasNotNullableValueTypeConstraint: bool
         HasDefaultConstructorConstraint: bool
         HasAllowsRefStruct: bool
@@ -1910,7 +1911,11 @@ let inline conditionalAdd condition flagToAdd source =
 let NoMetadataIdx = -1
 
 type InterfaceImpl =
-    { Idx: int; Type: ILType; mutable CustomAttrsStored: ILAttributesStored }
+    {
+        Idx: int
+        Type: ILType
+        mutable CustomAttrsStored: ILAttributesStored
+    }
 
     member x.CustomAttrs =
         match x.CustomAttrsStored with
@@ -1919,12 +1924,16 @@ type InterfaceImpl =
             x.CustomAttrsStored <- ILAttributesStored.Given res
             res
         | ILAttributesStored.Given attrs -> attrs
-
-    static member Create(ilType: ILType, customAttrsStored: ILAttributesStored) =
-        { Idx = NoMetadataIdx; Type = ilType; CustomAttrsStored = customAttrsStored }
 
-    static member Create(ilType: ILType) = InterfaceImpl.Create(ilType, emptyILCustomAttrsStored)
+    static member Create(ilType: ILType, customAttrsStored: ILAttributesStored) =
+        {
+            Idx = NoMetadataIdx
+            Type = ilType
+            CustomAttrsStored = customAttrsStored
+        }
 
+    static member Create(ilType: ILType) =
+        InterfaceImpl.Create(ilType, emptyILCustomAttrsStored)
 
 [<NoComparison; NoEquality; StructuredFormatDisplay("{DebugText}")>]
 type ILMethodDef
@@ -2575,17 +2584,15 @@ type ILTypeDefAdditionalFlags =
     | CanContainExtensionMethods = 1024
 
 let internal typeKindFlags =
-    ILTypeDefAdditionalFlags.Class |||
-    ILTypeDefAdditionalFlags.ValueType |||
-    ILTypeDefAdditionalFlags.Interface |||
-    ILTypeDefAdditionalFlags.Enum |||
-    ILTypeDefAdditionalFlags.Delegate
+    ILTypeDefAdditionalFlags.Class
+    ||| ILTypeDefAdditionalFlags.ValueType
+    ||| ILTypeDefAdditionalFlags.Interface
+    ||| ILTypeDefAdditionalFlags.Enum
+    ||| ILTypeDefAdditionalFlags.Delegate
 
-let inline internal resetTypeKind flags =
-    flags &&& ~~~typeKindFlags
+let inline internal resetTypeKind flags = flags &&& ~~~typeKindFlags
 
-let (|HasFlag|_|) (flag: ILTypeDefAdditionalFlags) flags =
-    flags &&& flag = flag
+let (|HasFlag|_|) (flag: ILTypeDefAdditionalFlags) flags = flags &&& flag = flag
 
 let inline typeKindByNames extendsName typeName =
     match extendsName with
@@ -2676,21 +2683,24 @@ type ILTypeDef
 
     let hasFlag flag = additionalFlags &&& flag = flag
 
-    new(name,
-        attributes,
-        layout,
-        implements,
-        genericParams,
-        extends,
-        methods,
-        nestedTypes,
-        fields,
-        methodImpls,
-        events,
-        properties,
-        additionalFlags,
-        securityDecls,
-        customAttrs) =
+    new
+        (
+            name,
+            attributes,
+            layout,
+            implements,
+            genericParams,
+            extends,
+            methods,
+            nestedTypes,
+            fields,
+            methodImpls,
+            events,
+            properties,
+            additionalFlags,
+            securityDecls,
+            customAttrs
+        ) =
         ILTypeDef(
             name,
             attributes,
@@ -2710,23 +2720,27 @@ type ILTypeDef
             NoMetadataIdx
         )
 
-    new(name,
-        attributes,
-        layout,
-        implements,
-        genericParams,
-        extends,
-        methods,
-        nestedTypes,
-        fields,
-        methodImpls,
-        events,
-        properties,
-        securityDecls,
-        customAttrs) =
+    new
+        (
+            name,
+            attributes,
+            layout,
+            implements,
+            genericParams,
+            extends,
+            methods,
+            nestedTypes,
+            fields,
+            methodImpls,
+            events,
+            properties,
+            securityDecls,
+            customAttrs
+        ) =
         let additionalFlags =
-            ILTypeDefAdditionalFlags.CanContainExtensionMethods |||
-            typeKindOfFlags name extends (int attributes)
+            ILTypeDefAdditionalFlags.CanContainExtensionMethods
+            ||| typeKindOfFlags name extends (int attributes)
+
         ILTypeDef(
             name,
             attributes,
@@ -2955,10 +2969,10 @@ and [<NoEquality; NoComparison>] ILPreTypeDef =
 and [<Sealed>] ILPreTypeDefImpl(nameSpace: string list, name: string, metadataIndex: int32, storage: ILTypeDefStored) =
     let stored =
         lazy
-        match storage with
-        | ILTypeDefStored.Given td -> td
-        | ILTypeDefStored.Computed f -> f ()
-        | ILTypeDefStored.Reader f -> f metadataIndex
+            match storage with
+            | ILTypeDefStored.Given td -> td
+            | ILTypeDefStored.Computed f -> f ()
+            | ILTypeDefStored.Reader f -> f metadataIndex
 
     interface ILPreTypeDef with
         member _.Namespace = nameSpace
@@ -4248,25 +4262,31 @@ let mkILStorageCtorWithParamNames (preblock: ILInstr list, ty, extraParams, flds
             | Some x -> I_seqpoint x
             | None -> ()
             yield! preblock
-            for (n, (_pnm, nm, fieldTy,_attrs)) in List.indexed flds do
+            for (n, (_pnm, nm, fieldTy, _attrs)) in List.indexed flds do
                 mkLdarg0
                 mkLdarg (uint16 (n + 1))
                 mkNormalStfld (mkILFieldSpecInTy (ty, nm, fieldTy))
         ]
 
     let body = mkMethodBody (false, [], 2, nonBranchingInstrsToCode code, tag, imports)
-    let fieldParams = 
+
+    let fieldParams =
         [
-            for (pnm,_,ty,attrs) in flds do
+            for (pnm, _, ty, attrs) in flds do
                 let ilParam = mkILParamNamed (pnm, ty)
+
                 let ilParam =
                     match attrs with
                     | [] -> ilParam
-                    | attrs -> {ilParam with CustomAttrsStored = storeILCustomAttrs (mkILCustomAttrs attrs ) }
+                    | attrs ->
+                        { ilParam with
+                            CustomAttrsStored = storeILCustomAttrs (mkILCustomAttrs attrs)
+                        }
+
                 yield ilParam
-        ]    
+        ]
 
-    mkILCtor (access, fieldParams @ extraParams , body)
+    mkILCtor (access, fieldParams @ extraParams, body)
 
 let mkILSimpleStorageCtorWithParamNames (baseTySpec, ty, extraParams, flds, access, tag, imports) =
     let preblock =

src/Compiler/AbstractIL/ilreflect.fs

@@ -164,7 +164,7 @@ type TypeBuilder with
             printfn "typeBuilder%d.CreateType()" (abs <| hash typB)
 
         //Buggy annotation in ns20, will not be fixed.
-#if NETSTANDARD && !NO_CHECKNULLS
+#if NETSTANDARD
         !!(typB.CreateTypeInfo()) :> Type
 #else
         typB.CreateTypeInfo() :> Type

src/Compiler/AbstractIL/ilwrite.fs

@@ -362,11 +362,7 @@ let envForOverrideSpec (ospec: ILOverridesSpec) = { EnclosingTyparCount=ospec.De
 //---------------------------------------------------------------------
 
 [<NoEquality; NoComparison>]
-type MetadataTable<'T
-#if !NO_CHECKNULLS
-    when 'T:not null
-#endif
-    > =
+type MetadataTable<'T when 'T:not null> =
     { name: string
       dict: Dictionary<'T, int> // given a row, find its entry number
       mutable rows: ResizeArray<'T> }

src/Compiler/DependencyManager/AssemblyResolveHandler.fsi

@@ -12,7 +12,7 @@ type AssemblyResolutionProbe = delegate of Unit -> seq<string>
 type AssemblyResolveHandler =
 
     /// Construct a new DependencyProvider
-    new: assemblyProbingPaths: AssemblyResolutionProbe|null -> AssemblyResolveHandler
+    new: assemblyProbingPaths: AssemblyResolutionProbe | null -> AssemblyResolveHandler
 
     /// Construct a new DependencyProvider
     internal new: assemblyProbingPaths: AssemblyResolutionProbe option -> AssemblyResolveHandler