Skip to content

Conversation

@T-Gro
Copy link
Member

@T-Gro T-Gro commented Nov 21, 2025

(network isolation need for signed builds)

@T-Gro T-Gro requested a review from a team as a code owner November 21, 2025 14:53
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Nov 21, 2025
@T-Gro T-Gro requested review from abonie and Copilot November 21, 2025 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

Copilot finished reviewing on behalf of T-Gro November 21, 2025 14:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces new test attributes to skip tests that require NuGet package restore when running in signed builds. Signed builds operate under network isolation for security reasons, which prevents NuGet package restoration from working. The PR adds three new xUnit test attributes (FactSkipOnSignedBuild, TheorySkipOnSignedBuild, and FactForNETCOREAPPSkipOnSignedBuild) that check the SIGNTYPE environment variable and skip tests when it equals "Real". These attributes are then applied to approximately 30 tests across the test suite that use #r "nuget:" directives or NuGet packages.

Key changes:

  • Added SignedBuildSkip module with reusable skip logic in test utilities
  • Created three new conditional skip attributes for different test scenarios
  • Applied skip attributes to FSI printing tests, regression tests, and scripting/dependency manager tests

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/FSharp.Test.Utilities/Utilities.fs Defines SignedBuildSkip module and three new test attributes (FactSkipOnSignedBuild, TheorySkipOnSignedBuild, FactForNETCOREAPPSkipOnSignedBuild) that check for signed builds via the SIGNTYPE environment variable
tests/fsharp/tests.fs Applies FactSkipOnSignedBuild attribute to FSI printing tests (which use NuGet via test.fsx) and large input regression tests (12322, 13219, 13710) that require NuGet packages
tests/FSharp.Compiler.Service.Tests/ProjectAnalysisTests.fs Marks one test that uses #r nuget directives with the skip attribute
tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs Applies skip attributes to multiple scripting tests that use NuGet packages, including ML.NET, FSharpPlus, and other NuGet-dependent scenarios
tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs Marks dependency manager tests that restore and use NuGet packages with the skip attribute

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Nov 25, 2025
@abonie abonie merged commit 5aa719d into main Nov 25, 2025
38 checks passed
@T-Gro T-Gro deleted the signed-build-no-nuget branch November 25, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants