IL: fix leaking binary view - #20250
Open
auduchinok wants to merge 2 commits into
Open
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
auduchinok
force-pushed
the
il-binaryViewLeak
branch
from
August 13, 2026 10:33
15a45f3 to
c3fff81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes binary view is kept instead of getting it in the lambda.
For non-framework assemblies a weak reference is used for metadata. However,
seekReadInterfaceImplscaptured the metadata view, so the metadata was kept in memory. For project with many non-framework references it retained a lot of memory.Retained memory after
ParseAndCheckProject:References distribution:
WeakByteFile(.nuget\packages)ByteFile