-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update to M.E.AI 9.4.0-preview.1.25207.5 #7439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- eng/Versions.props: Language not supported
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7439 +/- ##
=======================================
Coverage 68.98% 68.99%
=======================================
Files 1482 1482
Lines 273876 273876
Branches 28250 28254 +4
=======================================
+ Hits 188944 188961 +17
+ Misses 77550 77529 -21
- Partials 7382 7386 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
It doesn't look like that version has been mirrored internally? @stephentoub can we go straight to the 9.5.0 preview or do we need to stick to the 9.4.0 preview? |
What feed are you building against? The 9.4 one is the newest one on the public nuget. |
Noone in microsoft can use public NuGet. Needs to be mirrored to AzDo feed. https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md |
They're mirrored to our dotnet feeds already. I was pointing out that there's no 9.5 publicly on nuget, so machinelearning shouldn't depend on anything 9.5 because no one will be able to use it. |
Checking this - extensions publishes to dotnet9 feed normally https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet9/NuGet/Microsoft.Extensions.AI/versions But that version isn't present. Probably release branch is either publishing to different feed, or not at all. cc @joperezr |
I'd manually run the mirror on Tuesday for all of the M.E.AI packages, and that run completed successfully. I'm not sure why that wouldn't have resulted in them being mirrored. |
Yeah, looks like the release branches of dotnet/extensions aren't publishing to any feeds https://dev.azure.com/dnceng/internal/_build/results?buildId=2682494&view=logs&j=226748d0-f812-5437-d3f0-2dd291f5666e&t=b3ecf0d0-598d-5874-6547-0432d3f07f6b&l=66
|
Looks like the pr was created just a few minutes before the mirror finished. So its probably a race condition between the builds and the package feeds. |
Might have been a timing thing. The packages are in dotnet-public - but might not have been fully indexed at the time the build ran. |
No description provided.