Skip to content

Update to M.E.AI 9.4.0-preview.1.25207.5 #7439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Apr 8, 2025

No description provided.

@Copilot Copilot bot review requested due to automatic review settings April 8, 2025 21:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • eng/Versions.props: Language not supported

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.99%. Comparing base (87e1fec) to head (d9f4dc7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rosoft.ML.GenAI.Core/CausalLMPipelineChatClient.cs 0.00% 1 Missing ⚠️
...crosoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs 0.00% 1 Missing ⚠️
...rosoft.ML.GenAI.Phi/Phi3/Phi3CausalLMChatClient.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7439   +/-   ##
=======================================
  Coverage   68.98%   68.99%           
=======================================
  Files        1482     1482           
  Lines      273876   273876           
  Branches    28250    28254    +4     
=======================================
+ Hits       188944   188961   +17     
+ Misses      77550    77529   -21     
- Partials     7382     7386    +4     
Flag Coverage Δ
Debug 68.99% <0.00%> (+<0.01%) ⬆️
production 63.28% <0.00%> (+<0.01%) ⬆️
test 89.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rosoft.ML.GenAI.Core/CausalLMPipelineChatClient.cs 0.00% <0.00%> (ø)
...crosoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs 0.00% <0.00%> (ø)
...rosoft.ML.GenAI.Phi/Phi3/Phi3CausalLMChatClient.cs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelgsharp
Copy link
Member

It doesn't look like that version has been mirrored internally?
Microsoft.ML.GenAI.Core.Tests.csproj : error NU1603: Warning As Error: Microsoft.ML.GenAI.Core depends on Microsoft.Extensions.AI.Abstractions (>= 9.4.0-preview.1.25207.5) but Microsoft.Extensions.AI.Abstractions 9.4.0-preview.1.25207.5 was not found. Microsoft.Extensions.AI.Abstractions 9.5.0-preview.1.25203.1 was resolved instead. [D:\a\_work\1\s\Microsoft.ML.sln]

@stephentoub can we go straight to the 9.5.0 preview or do we need to stick to the 9.4.0 preview?

@stephentoub
Copy link
Member

It doesn't look like that version has been mirrored internally? Microsoft.ML.GenAI.Core.Tests.csproj : error NU1603: Warning As Error: Microsoft.ML.GenAI.Core depends on Microsoft.Extensions.AI.Abstractions (>= 9.4.0-preview.1.25207.5) but Microsoft.Extensions.AI.Abstractions 9.4.0-preview.1.25207.5 was not found. Microsoft.Extensions.AI.Abstractions 9.5.0-preview.1.25203.1 was resolved instead. [D:\a\_work\1\s\Microsoft.ML.sln]

@stephentoub can we go straight to the 9.5.0 preview or do we need to stick to the 9.4.0 preview?

What feed are you building against? The 9.4 one is the newest one on the public nuget.

@ericstj
Copy link
Member

ericstj commented Apr 10, 2025

Noone in microsoft can use public NuGet. Needs to be mirrored to AzDo feed. https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md

@stephentoub
Copy link
Member

stephentoub commented Apr 10, 2025

Noone in microsoft can use public NuGet. Needs to be mirrored to AzDo feed. https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md

They're mirrored to our dotnet feeds already. I was pointing out that there's no 9.5 publicly on nuget, so machinelearning shouldn't depend on anything 9.5 because no one will be able to use it.

@ericstj
Copy link
Member

ericstj commented Apr 10, 2025

Checking this - extensions publishes to dotnet9 feed normally https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet9/NuGet/Microsoft.Extensions.AI/versions

But that version isn't present. Probably release branch is either publishing to different feed, or not at all. cc @joperezr

@stephentoub
Copy link
Member

I'd manually run the mirror on Tuesday for all of the M.E.AI packages, and that run completed successfully. I'm not sure why that wouldn't have resulted in them being mirrored.

@ericstj
Copy link
Member

ericstj commented Apr 10, 2025

Yeah, looks like the release branches of dotnet/extensions aren't publishing to any feeds https://dev.azure.com/dnceng/internal/_build/results?buildId=2682494&view=logs&j=226748d0-f812-5437-d3f0-2dd291f5666e&t=b3ecf0d0-598d-5874-6547-0432d3f07f6b&l=66

I'd manually run the mirror on Tuesday for all of the M.E.AI packages, and that run completed successfully. I'm not sure why that wouldn't have resulted in them being mirrored.

Probably there was already a later version on nuget so it mirrored that to dotnet-public.
Not sure what's going on. Will rerun the mirror.

@michaelgsharp
Copy link
Member

Looks like the pr was created just a few minutes before the mirror finished. So its probably a race condition between the builds and the package feeds.

@ericstj
Copy link
Member

ericstj commented Apr 10, 2025

Might have been a timing thing. The packages are in dotnet-public - but might not have been fully indexed at the time the build ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants