[RGen] Update the class validator to deal with properties and fields. #23656

mandel-macaque · 2025-08-20T20:24:30Z

Add part of the class validator that will analyze a class and will check for several things in the propertites and methods:

Validates all fields and properties using the PropertyOrField validator.
Validates that WeakDelegates do not use the same strong delegate name.
Selectors are unique.

Added a end to end test for the class analyzer.

Weak delegate properties have to start with 'Weak' or provide a strong delegate name for the rgen to generate a unique valid name. Added tests to ensure that both the PropertyValidator and PropertyOrFieldValidator return the correct error.

Add part of the class validator that will analyze a class and will check for several things in the propertites and methods: 1. Validates all fields and properties using the PropertyOrField validator. 2. Validates that WeakDelegates do not use the same strong delegate name. 3. Selectors are unique. Added a end to end test for the class analyzer.

rolfbjarne · 2025-08-21T05:06:37Z

src/rgen/Microsoft.Macios.Bindings.Analyzer/Validators/ClassValidator.cs

+	/// <param name="diagnostics">When this method returns, contains diagnostics for any duplicate selectors; otherwise, an empty array.</param>
+	/// <param name="location">The code location to be used for the diagnostics.</param>
+	/// <returns><c>true</c> if all selectors are unique; otherwise, <c>false</c>.</returns>
+	bool SelectorsAreUnique (Binding binding, RootContext context,


Selectors can actually be duplicated, it's only a problem if they're exported, which doesn't happen if the [Sealed] attribute is present.

Here's an example:

macios/src/foundation.cs

Lines 5378 to 5388 in 052a9e9

[Internal]

[Sealed]

[Export ("replaceObjectAtIndex:withObject:")]

void _ReplaceObject (nint index, IntPtr withObject);

/// <param name="index">To be added.</param>

/// <param name="withObject">To be added.</param>

/// <summary>To be added.</summary>

/// <remarks>To be added.</remarks>

[Export ("replaceObjectAtIndex:withObject:")]

void ReplaceObject (nint index, NSObject withObject);

I think we can leave it as a warning that can be disabled with a #prama so that we know it is a not common situation.

vs-mobiletools-engineering-service2 · 2025-09-08T17:17:10Z

✅ [CI Build #1062fa8] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T17:17:35Z

✅ [PR Build #1062fa8] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T17:43:19Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T18:11:40Z

✅ [CI Build #1062fa8] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T18:23:42Z

💻 [CI Build #1062fa8] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T18:26:17Z

💻 [CI Build #1062fa8] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T18:27:11Z

💻 [CI Build #1062fa8] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T18:29:54Z

💻 [CI Build #1062fa8] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-08T19:46:13Z

🚀 [CI Build #1062fa8] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 121 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 1062fa8e497d027b0736ad4c8eec9eaaf0dcde84 [PR build]

mandel-macaque and others added 4 commits August 20, 2025 12:16

[RGen] Add the validation for weak delegates.

e054e62

Weak delegate properties have to start with 'Weak' or provide a strong delegate name for the rgen to generate a unique valid name. Added tests to ensure that both the PropertyValidator and PropertyOrFieldValidator return the correct error.

Auto-format source code

b80b8c8

Auto-format source code

717347d

dalexsoto approved these changes Aug 20, 2025

View reviewed changes