[messaging] Fixed environment variables logic on Build Agent #23676
Conversation
This comment has been minimized.
This comment has been minimized.
We were setting a custom home folder (.home directory defined in the DOTNET_CUSTOM_HOME env var) when the dotnet SDK was installed by Pair To Mac, to encapsulate caches and to not mix them with the global dotnet installation: https://github.com/dotnet/macios/blob/main/msbuild/Messaging/Xamarin.Messaging.Build/TaskRunner.cs#L62C4-L66C6 If the user assigns the global dotnet installation to the "_DotNetRootRemoteDirectory" MSBuild property, the Build agent will end up overriding the HOME folder with a custom home that doesn't exist (there's no .home folder in the user profile in the Mac (where dotnet installs the global caches). This issue has been revealed from the recent changes that allows the MSBuild client to bypass the "_DotNetRootRemoteDirectory" property to the Build Agent: https://dev.azure.com/devdiv/DevDiv/_git/ClientTools.Platform/pullrequest/663026 The fix consists of setting the custom home only if the dotnet SDK path to use is not the global one
mauroa
force-pushed
the
dev/maagno/main
branch
from
8291f24 to
10649a0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #15bd0b4] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #15bd0b4] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #15bd0b4] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #15bd0b4] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #15bd0b4] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #15bd0b4] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #15bd0b4] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #15bd0b4] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 128 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
We were setting a custom home folder (.home directory defined in the DOTNET_CUSTOM_HOME env var) when the dotnet SDK was installed by Pair To Mac, to encapsulate caches and to not mix them with the global dotnet installation: https://github.com/dotnet/macios/blob/main/msbuild/Messaging/Xamarin.Messaging.Build/TaskRunner.cs#L62C4-L66C6 If the user assigns the global dotnet installation to the "_DotNetRootRemoteDirectory" MSBuild property, the Build agent will end up overriding the HOME folder with a custom home that doesn't exist (there's no .home folder in the user profile in the Mac (where dotnet installs the global caches). This issue has been revealed from the recent changes that allows the MSBuild client to bypass the "_DotNetRootRemoteDirectory" property to the Build Agent: https://dev.azure.com/devdiv/DevDiv/_git/ClientTools.Platform/pullrequest/663026 The fix consists of setting the custom home only if the dotnet SDK path to use is not the global one --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>
We were setting a custom home folder (.home directory defined in the DOTNET_CUSTOM_HOME env var) when the dotnet SDK was installed by Pair To Mac, to encapsulate caches and to not mix them with the global dotnet installation: https://github.com/dotnet/macios/blob/main/msbuild/Messaging/Xamarin.Messaging.Build/TaskRunner.cs#L62C4-L66C6
If the user assigns the global dotnet installation to the "_DotNetRootRemoteDirectory" MSBuild property, the Build agent will end up overriding the HOME folder with a custom home that doesn't exist (there's no .home folder in the user profile in the Mac (where dotnet installs the global caches).
This issue has been revealed from the recent changes that allows the MSBuild client to bypass the "_DotNetRootRemoteDirectory" property to the Build Agent: https://dev.azure.com/devdiv/DevDiv/_git/ClientTools.Platform/pullrequest/663026
The fix consists of setting the custom home only if the dotnet SDK path to use is not the global one