[src] Significant upgrades to DictionaryContainer. #23724

rolfbjarne · 2025-09-02T16:15:16Z

Simplified and unified a lot of code.
Updated and added a lot of xml docs.
Added tests.
Expanded a bit on the exposed API to support more types.
Found and fixed a bug with CVPixelFormatComponentRange, it was bound as a strong
dictionary, when it's supposed to be a strong enum.

* Simplified and unified a lot of code. * Updated and added a lot of xml docs. * Added tests. * Expanded a bit on the exposed API to support more types. * Found and fixed a bug with CVPixelFormatComponentRange, it was bound as a strong dictionary, when it's supposed to be a strong enum.

dalexsoto

👍

vs-mobiletools-engineering-service2 · 2025-09-03T17:30:49Z

✅ [CI Build #a1dacc4] Build passed (Build packages) ✅

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T17:31:26Z

✅ [PR Build #a1dacc4] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T18:10:16Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T18:26:14Z

✅ [CI Build #a1dacc4] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T18:42:53Z

💻 [CI Build #a1dacc4] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T18:45:06Z

💻 [CI Build #a1dacc4] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T18:46:21Z

💻 [CI Build #a1dacc4] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T18:47:26Z

💻 [CI Build #a1dacc4] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T19:51:54Z

✅ [PR Build #27e6952] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 27e6952080640b31937b6c1c269965830396ffc8 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T20:16:40Z

✅ [CI Build #27e6952] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 27e6952080640b31937b6c1c269965830396ffc8 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T20:25:20Z

💻 [CI Build #27e6952] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 27e6952080640b31937b6c1c269965830396ffc8 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T20:31:08Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 27e6952080640b31937b6c1c269965830396ffc8 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T20:32:17Z

💻 [CI Build #27e6952] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 27e6952080640b31937b6c1c269965830396ffc8 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T20:38:03Z

💻 [CI Build #27e6952] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 27e6952080640b31937b6c1c269965830396ffc8 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-03T20:42:44Z

💻 [CI Build #27e6952] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 27e6952080640b31937b6c1c269965830396ffc8 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-04T05:55:40Z

💻 [CI Build #a1dacc4] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

vs-mobiletools-engineering-service2 · 2025-09-04T07:14:30Z

🚀 [CI Build #a1dacc4] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a1dacc4bbbe1919a3ebc6faca2172a3ab0a54e66 [PR build]

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 2, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne and others added 3 commits September 3, 2025 08:47

Adjust test.

5b7fcbd

Add GetNSObject signature for NativeAOT

59b468e

[CI][Tests]Move x64 sonoma tests to the shared pool (#23725)

63e412a

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits September 3, 2025 18:12

Fix API

27e6952

Fix bgen

a1dacc4

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review September 4, 2025 06:32

rolfbjarne merged commit f8a3883 into xcode26.0 Sep 4, 2025
45 checks passed

rolfbjarne deleted the dev/rolf/dictionarycontainer-upgrades branch September 4, 2025 07:21

[src] Significant upgrades to DictionaryContainer. #23724

[src] Significant upgrades to DictionaryContainer. #23724

Uh oh!

Conversation

rolfbjarne commented Sep 2, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 3, 2025

✅ [CI Build #a1dacc4] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

✅ [PR Build #a1dacc4] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

✅ [CI Build #a1dacc4] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

💻 [CI Build #a1dacc4] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 3, 2025

💻 [CI Build #a1dacc4] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

💻 [CI Build #a1dacc4] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

💻 [CI Build #a1dacc4] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 3, 2025

✅ [PR Build #27e6952] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

✅ [CI Build #27e6952] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

💻 [CI Build #27e6952] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 3, 2025

💻 [CI Build #27e6952] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!