[iOS] Fix for CarouselView ItemSpacing property in ItemsLayout not working with CV2 #27056
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
vishnumenon2684
added
the
partner/syncfusion
|
Hi @mattleibow, I have fixed the ItemSpacing issue in CarouselViewHandler2.iOS, which resolves the issues on both iOS and macOS. While testing to enable the test case in MacCatalyst, maximizing the window resulted in different behaviors in CV1 and CV2. As a result, I have not enabled the MacCatalyst condition yet. Could you please confirm the correct behavior on macOS—CV1 or CV2? Issue link : #26969 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 14, 2025
| @@ -83,7 +82,10 @@ protected override UICollectionViewLayout SelectLayout() | |||
|
|
|||
| // Create our section layout | |||
| var section = NSCollectionLayoutSection.Create(group: group); | |||
| section.InterGroupSpacing = itemSpacing; | |||
| if (VirtualView.ItemsLayout is LinearItemsLayout linearItemsLayout) | |||
There was a problem hiding this comment.
Could include a related test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
The itemSpacing variable is initialized to 0. As a result, itemSpacing remains 0, and no spacing is applied between the items.
Description of Change
To resolve this, apply the correct item spacing from the LinearItemsLayout.
Issues Fixed
Fixes #27025
Tested the behaviour in the following platforms
Screenshot