[Windows] Fixed Margin Not Applied to Shell Flyout Template Items on First Display #27060
+67
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @prakashKannanSf3972! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
sheiksyedm
added
the
partner/syncfusion
|
/rebase |
github-actions
bot
force-pushed
the
fix-18423
branch
from
534b265 to
290749b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 13, 2025
|
|
||
| [Test] | ||
| [Category(UITestCategories.Shell)] | ||
| public void VerifyTemplateViewMarginOnInitialDisplay() |
There was a problem hiding this comment.
The test is failing on Windows:
System.TimeoutException : Timed out waiting for element...
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2163
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2180
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 665
at Microsoft.Maui.TestCases.Tests.Issues.Issue18423.VerifyTemplateViewMarginOnInitialDisplay() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18423.cs:line 19
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
There was a problem hiding this comment.
The test is failing on Windows:
System.TimeoutException : Timed out waiting for element... at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2163 at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2180 at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 665 at Microsoft.Maui.TestCases.Tests.Issues.Issue18423.VerifyTemplateViewMarginOnInitialDisplay() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18423.cs:line 19 at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor) at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
@jsuarezruiz , Thank you for pointing this out. Addressed the issue by updating the test logic and believe it will not fail in the next CI run.
There was a problem hiding this comment.
Nice, thanks. The Windows snapshot is pending, could you commit it? Available in the latest build.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 14, 2025
|
|
||
| [Test] | ||
| [Category(UITestCategories.Shell)] | ||
| public void VerifyTemplateViewMarginOnInitialDisplay() |
There was a problem hiding this comment.
Nice, thanks. The Windows snapshot is pending, could you commit it? Available in the latest build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The ActualWidth value is checked before it is updated, as it only reflects the correct value after the ArrangeOverride method completes. This premature check returns zero, preventing proper arrangement of the item view, as necessary values are not passed during the initial layout phase.
Description of Change
The ArrangeOverride method was updated to execute arrangement logic only when finalSize has valid dimensions. This prevents layout issues caused by invalid sizes and ensures proper arrangement of the view. If these conditions are not met, the base implementation is used as a fallback.
Issues Fixed
Fixes #18423
Tested the behaviour in the following platforms
Output
Before-Fix.mp4
After-Fix.mp4