Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Disabled animation for NavigationBar on initial display #27080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jan 12, 2025

Description of Change

This PR disables the animation for showing or hiding the navigation bar when a page is displayed for the first time by setting Shell.NavBarIsVisible. Subsequent changes to Shell.NavBarIsVisible remain unaffected and will animate (maybe they shouldn't though? On Android, displaying or hiding the navigation bar does not involve any navigation transitions)

Issues Fixed

Fixes #26994

Before After
Screen.Recording.2025-01-12.at.02.51.47.mov
Screen.Recording.2025-01-12.at.02.45.59.mov

@kubaflo kubaflo requested a review from a team as a code owner January 12, 2025 01:55
@kubaflo kubaflo added platform/iOS 🍎 area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution labels Jan 12, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

@PureWeen Thoughts?

@PureWeen
Copy link
Member

Description of Change

This PR disables the animation for showing or hiding the navigation bar when a page is displayed for the first time by setting Shell.NavBarIsVisible. Subsequent changes to Shell.NavBarIsVisible remain unaffected and will animate (maybe they shouldn't though? On Android, displaying or hiding the navigation bar does not involve any navigation transitions)

Issues Fixed

Fixes #26994

Before After
Screen.Recording.2025-01-12.at.02.51.47.mov
Screen.Recording.2025-01-12.at.02.45.59.mov

Can you post your sample that you're reproing here?

I'm having a little trouble mapping your description to the issue the user has logged.
Also, the action you're taking in the two videos is different

@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 16, 2025

Description of Change

This PR disables the animation for showing or hiding the navigation bar when a page is displayed for the first time by setting Shell.NavBarIsVisible. Subsequent changes to Shell.NavBarIsVisible remain unaffected and will animate (maybe they shouldn't though? On Android, displaying or hiding the navigation bar does not involve any navigation transitions)

Issues Fixed

Fixes #26994
Before After
Screen.Recording.2025-01-12.at.02.51.47.mov
Screen.Recording.2025-01-12.at.02.45.59.mov

Can you post your sample that you're reproing here?

I'm having a little trouble mapping your description to the issue the user has logged. Also, the action you're taking in the two videos is different

<Shell
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    x:Class="Maui.Controls.Sample.SandboxShell"
    Background="Red"
    Shell.ForegroundColor="White"
    xmlns:local="clr-namespace:Maui.Controls.Sample"
    x:Name="shell">
    <TabBar>
        <Tab Title="MainPage1">
            <ContentPage
                Background="Green"
                Title="Page1"/>
        </Tab>
        <Tab Title="MainPage1">
            <ShellContent Title="wwa"
                          Route="wwa">
                <ShellContent.ContentTemplate>
                    <DataTemplate>
                        <ContentPage Background="Red"
                                     Shell.NavBarIsVisible="False"
                                     Title="Page1"/>
                    </DataTemplate>
                </ShellContent.ContentTemplate>
            </ShellContent>
        </Tab>
    </TabBar>
</Shell>
Screen.Recording.2025-01-17.at.00.34.29.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Shell.NavBarIsVisible="False" briefly displays navigation bar and disappears
3 participants