[Android] SpacingItemDecoration improvement #27093
Open
+144
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Jan 13, 2025
| @@ -477,8 +477,7 @@ protected virtual void UpdateItemSpacing() | |||
| // We need to adjust the padding on the RecyclerView so this spacing isn't visible around the outer edge of our control. | |||
| // Horizontal & vertical spacing should only exist between items. | |||
| var horizontalPadding = -spacingDecoration.HorizontalOffset; | |||
| var verticalPadding = -spacingDecoration.VerticalOffset; | |||
| SetPadding(horizontalPadding, verticalPadding, horizontalPadding, verticalPadding); | |||
| SetPadding(horizontalPadding, 0, horizontalPadding, 0); | |||
There was a problem hiding this comment.
Could you include a test?
There was a problem hiding this comment.
I'm not sure how. I don't think we can test it. Maybe you have an idea perhaps?
There was a problem hiding this comment.
It doesn't affect the UI, but the rendering time when creating cells, right?
There was a problem hiding this comment.
can we just compare screenshot ?
There was a problem hiding this comment.
Right, a UI test with consistent screenshots after scrolling the CV should be trustworthy
There was a problem hiding this comment.
@rmarinho @jsuarezruiz added :)
This was referenced Jan 14, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Vertical padding set on the recyclerView affected the rendering process. It is much more efficient to fully rely on ItemDecoration to manage spacing between items.
Issues Fixed
Fixes #24511
Fixes #8422
Screen.Recording.2025-01-13.at.11.51.36.mov
Screen.Recording.2025-01-13.at.11.49.06.mov
Screen.Recording.2025-01-14.at.10.49.40.mov
Screen.Recording.2025-01-14.at.10.46.01.mov