Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the VS channel change requirement in release-checklist.md #11268

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

JanKrivanek
Copy link
Member

Context

We have issues with our OptProf pipeline for release branches. Part of the problem was caused by mismatched usage of VS and MSbuild. To prevent this we need to use a matching VS channel in our build.

Testing

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10817064&view=results

@SimaTian
Copy link
Member

Should we maybe first merge #11131 to avoid merge conflicts?
Also please remove me from PRs last commit, I'm unsure why the "update branch" hijacks the autorship by adding me as a contributor when I only clicked one button. I'm sorry for that.

@JanKrivanek
Copy link
Member Author

Merged with the other doc update.
No worries about authorship. Btw. the "Update Branch" should rarely be needed, and when it is - it might be more clean to do a rebase localy.

@SimaTian SimaTian merged commit f077a17 into main Jan 20, 2025
10 checks passed
@SimaTian SimaTian deleted the JanKrivanek-patch-7 branch January 20, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants