Skip to content

.NET 6 & 7 build fix #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

.NET 6 & 7 build fix #3475

merged 1 commit into from
Nov 9, 2023

Conversation

adamsitnik
Copy link
Member

.NET 8 introduced new APIs for Sockets: dotnet/runtime#30797

I don't blame @wfurt who added new benchmarks in #3211, because our CI does not run for all supported tfms (#2732)

image

@adamsitnik adamsitnik requested a review from wfurt November 8, 2023 12:08
@wfurt
Copy link
Member

wfurt commented Nov 8, 2023

should CI run alder versions as well? This is likely hit anybody who adds new tests....

@cincuranet cincuranet merged commit 69c0d4c into dotnet:main Nov 9, 2023
@adamsitnik adamsitnik deleted the socketsBuildFix branch November 9, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants