Use the new INotifyProcess1800 API from debugger #9763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd enhance debugging interfaces
…d improve Hot Reload support checks
…ovider for improved process management and Hot Reload state handling
drewnoakes
reviewed
Sep 10, 2025
...lStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/LaunchProfilesDebugLaunchProvider.cs
Outdated
Show resolved
Hide resolved
...lStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/LaunchProfilesDebugLaunchProvider.cs
Outdated
Show resolved
Hide resolved
...VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/ProjectLaunchTargetsProvider.cs
Outdated
Show resolved
Hide resolved
...VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/ProjectLaunchTargetsProvider.cs
Outdated
Show resolved
Hide resolved
...VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/ProjectLaunchTargetsProvider.cs
Outdated
Show resolved
Hide resolved
…oved debugging support
… process handling and remove unused code from ProjectLaunchTargetsProvider
LittleLittleCloud
changed the title
…ovider to improve code clarity and remove unused dependencies
…ReloadSessionManager class to improve clarity and remove unused dependencies
…anager to mark obsolete methods and improve session management; add unit tests for Hot Reload session functionality
drewnoakes
reviewed
Sep 12, 2025
...lStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/LaunchProfilesDebugLaunchProvider.cs
Outdated
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
...tudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/IDebugProfileLaunchTargetsProvider5.cs
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
...System.Managed.VS.UnitTests/ProjectSystem/VS/Debug/LaunchProfilesDebugLaunchProviderTests.cs
Show resolved
Hide resolved
...ojectSystem.Managed.VS.UnitTests/ProjectSystem/VS/Debug/ProjectLaunchTargetsProviderTests.cs
Show resolved
Hide resolved
|
Looks like the public API files need updating. |
…mprove documentation and remove obsolete methods; update session state handling in ProjectHotReloadSessionManager and enhance unit tests for clarity and maintainability
…y method references and update Public API declaration for OnAfterLaunchAsync
…ling by optimizing the removal of active session states and updating the hot reload state notification logic.
drewnoakes
approved these changes
Sep 14, 2025
...tudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/IDebugProfileLaunchTargetsProvider5.cs
Outdated
Show resolved
Hide resolved
...lStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Debug/LaunchProfilesDebugLaunchProvider.cs
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Show resolved
Hide resolved
...Studio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/ProjectHotReloadSessionManager.cs
Outdated
Show resolved
Hide resolved
|
|
||
| public Task ActivateSessionAsync(IVsLaunchedProcess launchedProcess, VsDebugTargetProcessInfo vsDebugTargetProcessInfo) | ||
| { | ||
| Assumes.NotNull(_pendingSessionState); |
There was a problem hiding this comment.
Worth including a message here to make triaging any violations of this easier.
Suggested change
| Assumes.NotNull(_pendingSessionState); | |
| Assumes.NotNull(_pendingSessionState, "No pending hot reload session to activate."); |
…aunchProvider to correct documentation and improve session handling; update IProjectHotReloadSessionManagerFactory for method signature consistency.
drewnoakes
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.