Add lsp mapping service #11673
Open
Add lsp mapping service #11673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Mar 28, 2025
| Debug.Assert(response.Spans.Length == spans.Count(), "The number of mapped spans should match the number of input spans."); | ||
| Debug.Assert(response.Ranges.Length == spans.Count(), "The number of mapped ranges should match the number of input spans."); | ||
|
|
||
| var builder = ImmutableArray.CreateBuilder<RazorMappedSpanResult>(response.Spans.Length); |
There was a problem hiding this comment.
Consider using a PooledArrayBuilder<RazorMappedSpanResult>.
| builder.Add(new RazorMappedSpanResult(filePath, range.ToLinePositionSpan(), span.ToTextSpan())); | ||
| } | ||
|
|
||
| return builder.ToImmutable(); |
There was a problem hiding this comment.
Use DrainToImmutable since you set the capacity to the exact length.
davidwengier
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly unintersting. The work in typescript will be to call to existing RazorMapToDocument{Ranges, Edits}Endpoint and translate the responses accordingly. Since this is calling from the Roslyn language server it doesn't know the mapping from csharp document uri to razor uri so we can't reuse the same params to call the endpoints "directly" (as in no translation logic in typescript).
Fixes #9369