Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IncrementalParsingTests.TestDiffsInOrder #76940

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Jan 27, 2025

As part of #76867, we found a bug in this helper for incremental parsing tests. Porting the fix back to main branch

@jcouv jcouv added Area-Compilers Test Test failures in roslyn-CI labels Jan 27, 2025
@jcouv jcouv self-assigned this Jan 27, 2025
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 27, 2025
@jcouv jcouv changed the title Fix TestDiffsInOrder Fix IncrementalParsingTests.TestDiffsInOrder Jan 27, 2025
@jcouv jcouv marked this pull request as ready for review January 27, 2025 21:20
@jcouv jcouv requested a review from a team as a code owner January 27, 2025 21:20
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jcouv jcouv merged commit d275717 into dotnet:main Jan 28, 2025
24 checks passed
@jcouv jcouv deleted the fix-incremental branch January 28, 2025 17:14
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test Test failures in roslyn-CI untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants