Improve CS9105 in static context#82472
Open
stevenelliottjr wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
When a primary constructor parameter is referenced from a static member
of the same declaring type, report the new CS9360 error with the message
"Cannot use primary constructor parameter '{name}' in a static member."
instead of the generic CS9105 "Cannot use primary constructor parameter
'{type name}' in this context."
This follows the same pattern used for extension parameters
(ERR_ExtensionParameterInStaticContext) and provides clearer guidance,
similar to how CS0026 explicitly mentions static context for 'this'.
The generic CS9105 continues to be reported for other invalid contexts:
nested types, non-primary constructors, attribute arguments, and
parameter default values.
dotnet-policy-service
bot
added
the
Community
jjonescz
approved these changes
Feb 23, 2026
Comment on lines
+2090
to
+2091
| if (this.ContainingMember() is { IsStatic: true } && !InParameterDefaultValue && !InAttributeArgument && | ||
| (object)this.ContainingMember().ContainingSymbol == primaryCtor.ContainingSymbol) |
Member
There was a problem hiding this comment.
Perhaps we could do something like this to avoid calling ContainingMember() twice (since it seems to do potentially non-trivial work):
Suggested change
| if (this.ContainingMember() is { IsStatic: true } && !InParameterDefaultValue && !InAttributeArgument && | |
| (object)this.ContainingMember().ContainingSymbol == primaryCtor.ContainingSymbol) | |
| if (this.ContainingMember() is { IsStatic: true } containingMember && !InParameterDefaultValue && !InAttributeArgument && | |
| (object)containingMember.ContainingSymbol == primaryCtor.ContainingSymbol) |
AlekseyTs
reviewed
Feb 23, 2026
| { | ||
| Error(diagnostics, ErrorCode.ERR_InvalidPrimaryConstructorParameterReference, node, parameter); | ||
| // Give a better error for the simple case of using a primary constructor parameter in a static member | ||
| if (this.ContainingMember() is { IsStatic: true } && !InParameterDefaultValue && !InAttributeArgument && |
Contributor
AlekseyTs
reviewed
Feb 23, 2026
| { | ||
| Error(diagnostics, ErrorCode.ERR_InvalidPrimaryConstructorParameterReference, node, parameter); | ||
| // Give a better error for the simple case of using a primary constructor parameter in a static member | ||
| if (this.ContainingMember() is { IsStatic: true } && !InParameterDefaultValue && !InAttributeArgument && |
Contributor
Contributor
|
Done with review pass (commit 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82423
When a primary constructor parameter is referenced from a static member of the same declaring type, the compiler now reports the new CS9360 with the message:
instead of the generic CS9105:
This follows the same pattern used for extension parameters (
ERR_ExtensionParameterInStaticContext, added in #81606) and provides clearer guidance, similar to how CS0026 explicitly calls out static context forthis.What changed
ERR_PrimaryConstructorParameterInStaticContext = 9360Test plan
PrimaryConstructorTests.ParameterScopeparametrized test data (8231 test cases, all pass)Initializers_02,Initializers_03,ParameterCapturing_043/044/159,ShadowedByMemberFromBase_21RecordTests.Initializers_02/03,RecordTests.FieldAsPositionalMember_ConstRecordStructTests.Initializers_02/03ShadowedByMemberFromBase_22), other constructors (ShadowedByMemberFromBase_23), and attribute arguments